Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose the ESM2 data random seed via CLI #467

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

expose the ESM2 data random seed via CLI #467

wants to merge 1 commit into from

Conversation

pstjohn
Copy link
Collaborator

@pstjohn pstjohn commented Nov 21, 2024

Exposes the ESM2DataModule's seed via the train_esm2 CLI.

@pstjohn pstjohn requested a review from dorotat-nv November 21, 2024 16:00
@pstjohn
Copy link
Collaborator Author

pstjohn commented Nov 21, 2024

/build-ci

@pstjohn pstjohn enabled auto-merge (squash) November 21, 2024 16:00
dorotat-nv
dorotat-nv requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@dorotat-nv dorotat-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about seeding plt, numpy or pytorch? Used to be achieved with pl.seed_everything(seed). Is it somewhere under the hood in our codebase?

@pstjohn pstjohn force-pushed the pstjohn/esm2-seed-cli-arg branch from 80f5c51 to f78c913 Compare November 21, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorotat-nv dorotat-nv dorotat-nv requested changes

@jstjohn jstjohn Awaiting requested review from jstjohn jstjohn is a code owner

@malcolmgreaves malcolmgreaves Awaiting requested review from malcolmgreaves malcolmgreaves is a code owner

@skothenhill-nv skothenhill-nv Awaiting requested review from skothenhill-nv skothenhill-nv is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pstjohn @dorotat-nv