Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different model parallelism in pretrain/fine-tune or pretrain1/pretrain2 checkpoints. #276

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

jstjohn
Copy link
Collaborator

@jstjohn jstjohn commented Oct 8, 2024

@jstjohn jstjohn added the bug_fix_for_v24.10 all features going into v24.10 release both for bionemo1 and main label Oct 8, 2024
@jstjohn jstjohn self-assigned this Oct 8, 2024
@jstjohn
Copy link
Collaborator Author

jstjohn commented Oct 8, 2024

/build-ci

@jstjohn jstjohn changed the title Fix load checkpoint change TP bug Allow different model parallelism in pretrain/fine-tune or pretrain1/pretrain2 checkpoints. Oct 8, 2024
@jstjohn
Copy link
Collaborator Author

jstjohn commented Oct 8, 2024

/build-ci

@sichu2023 sichu2023 self-requested a review October 8, 2024 16:03
Copy link
Collaborator

@sichu2023 sichu2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jstjohn jstjohn merged commit f418059 into main Oct 8, 2024
14 checks passed
@jstjohn jstjohn deleted the jstjohn/fix-checkpoint-tp-change-issue branch October 8, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug_fix_for_v24.10 all features going into v24.10 release both for bionemo1 and main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants