Add new paths for nemo2 checkpoints and update docs to use them #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstjohn
requested review from
malcolmgreaves,
skothenhill-nv,
farhadrgh,
dorotat-nv,
gwarmstrong,
jomitchellnv and
pstjohn
as code owners
jstjohn
force-pushed
the
jstjohn/nemo2_checkpoints
branch
from
ddb7f69 to
1073053
Compare
|
/build-ci |
1 similar comment
|
/build-ci |
pstjohn
approved these changes
Oct 3, 2024
sub-packages/bionemo-geneformer/tests/bionemo/geneformer/test_model.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-testing/src/bionemo/testing/data/resources/esm2.yaml
Outdated
Show resolved
Hide resolved
farhadrgh
approved these changes
Oct 3, 2024
jstjohn
force-pushed
the
jstjohn/nemo2_checkpoints
branch
from
1073053 to
e114ed7
Compare
|
/build-ci |
farhadrgh
reviewed
Oct 3, 2024
cspades
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Works on my side (at least the model resource configs and downloading using bionemo_test_data_path since I'm using an older Docker container without download_bionemo_data installed yet).
$ bionemo_test_data_path esm2/650m:2.0 --source pbss
/workspace/bionemo2/.cache/bionemo/975d29ee980fcb08c97401bbdfdcf8ce-esm2_650M_nemo2.tar.gz.untar
* add ESM2 pretrain data to download_bionemo_data * update model overview readme
…-fw-ea into jstjohn/nemo2_checkpoints
|
/build-ci |
|
/build-ci |
sichu2023
reviewed
Oct 3, 2024
sub-packages/bionemo-testing/src/bionemo/testing/data/resources/esm2.yaml
Outdated
Show resolved
Hide resolved
sichu2023
reviewed
Oct 3, 2024
sub-packages/bionemo-testing/src/bionemo/testing/data/resources/esm2.yaml
Outdated
Show resolved
Hide resolved
|
/build-ci |
Signed-off-by: sichu2023 <[email protected]>
|
/build-ci |
6 tasks
|
/build-ci |
skothenhill-nv
approved these changes
Oct 4, 2024
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
bionemo_test_data_pathtodownload_bionemo_data.from_checkpointstyle functions to accept atagorpathobject. #242 to track task to create a tag based path system for specifying checkpoints to the CLI.