Conversation
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
…ndent anymore Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
…ckages that are now gone Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1517 +/- ##
==========================================
+ Coverage 79.25% 81.62% +2.36%
==========================================
Files 93 68 -25
Lines 6767 5196 -1571
==========================================
- Hits 5363 4241 -1122
+ Misses 1404 955 -449
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
…odles that depends on the license file for maturin Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
jomitchellnv
left a comment
There was a problem hiding this comment.
I suggest we do not merge until post GTC
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
Signed-off-by: John St. John <jstjohn@nvidia.com>
There was a problem hiding this comment.
A lot of this is edited out, but I wonder if we still need this file at all?
Description
Remove all NeMo2/Megatron-LM dependencies from the repository, delete stale sub-packages, and modernize the framework CI to use a lightweight per-sub-package matrix strategy matching the recipes CI pattern.
What was deleted (~100 files)
Megatron-LMandNeMogit submodules removed.bionemo-example_model,bionemo-llm,bionemo-testing— all depended on NeMo2/Megatron-Core and are no longer maintained.Dockerfile,pyproject.toml,requirements-cve.txt,requirements-dev.txt,requirements-test.txt— packages now define their own dependencies in theirpyproject.toml..devcontainer/framework/removed (only one devcontainer remains).ci/scripts/pytest_runner.sh,run_pytest_unittests.sh,run_pytest_slow.sh,run_pytest_notebooks.sh— replaced by per-package install in the workflow itself.CI overhaul
unit-tests-framework.ymlrewritten to match theunit-tests-recipes.ymlpattern: each sub-package runs in its own matrix job with a lightweight PyTorch container image, installing only its own dependencies.tach.tomlat CI time instead of being hardcoded. When a package changes, its downstream dependents are automatically included in the test matrix.bionemo-noodlesgets a.ci_build.shfor Rust toolchain installation (maturin/pyo3 build).carryforward: trueso partial runs don't cause coverage to appear to drop.LICENSE/directory so sub-package LICENSE symlinks resolve correctly.Docs cleanup
bionemo2path references updated tobionemothroughout.gen_ref_pages.pynow rewrites relative links when copying recipe READMEs into the docs tree, so source files can use relative paths while the compiled docs still resolve correctly.Structure changes
.devcontainer/recipes/to.devcontainer/(single devcontainer).pyproject.tomlsplit: ruff config →.ruff.toml, pytest config →pytest.ini.tach.tomlrewritten with accurate module definitions and dependencies for the remaining 8 sub-packages.bionemo-webdatamodule:lightningadded as an explicit dependency in itspyproject.toml.Type of changes