-
Notifications
You must be signed in to change notification settings - Fork 116
Refactor the way that we do weight decay skipping for hyena to follow ToT mbridge. #1429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… mbridge ToT. Signed-off-by: John St. John <[email protected]>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughThe PR updates Megatron dependency versions and refactors weight-decay embedding handling in Evo2 by introducing a dedicated Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~28 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Depends on NVIDIA-NeMo/Megatron-Bridge#2010 |
|
/ok to test dcadb56 |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
bionemo-recipes/recipes/evo2_megatron/src/bionemo/evo2/recipes/evo2.py
Outdated
Show resolved
Hide resolved
…dings variable Signed-off-by: John St. John <[email protected]>
|
/ok to test e71d3a3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@bionemo-recipes/recipes/evo2_megatron/src/bionemo/evo2/recipes/evo2.py`:
- Around line 246-248: The HyenaOptimizerConfigOverrideProvider is hardcoding
no_weight_decay_embeddings=True which ignores the recipe default and CLI flag;
change the call to forward the actual configured value instead of True (e.g.,
no_weight_decay_embeddings=no_weight_decay_embeddings or
no_weight_decay_embeddings=self.config.optimizer.no_weight_decay_embeddings /
the passed-in optimizer flag) so the provider respects the recipe/CLI setting;
update the invocation of HyenaOptimizerConfigOverrideProvider to use the
existing config/parameter name rather than a literal True.
In `@bionemo-recipes/recipes/evo2_megatron/tests/bionemo/evo2/run/test_train.py`:
- Around line 535-539: The docstring for the fixture mbridge_checkpoint_7b_1m
still says "Session-scoped" even though the fixture scope is module; update the
docstring to say "Module-scoped" (or remove the scope mention) and adjust the
following sentence if needed to reflect that the fixture exists for the duration
of the module's tests so it no longer implies session lifetime.
bionemo-recipes/recipes/evo2_megatron/tests/bionemo/evo2/run/test_train.py
Show resolved
Hide resolved
Signed-off-by: John St. John <[email protected]>
|
/ok to test 01f238c |
Signed-off-by: John St. John <[email protected]>
|
/ok to test 1f7235d |
Description
Usage
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels. By default, only basic unit tests are run.
Unit tests marked as
@pytest.mark.multi_gpuor@pytest.mark.distributedare not run in the PR pipeline.For more details, see CONTRIBUTING
Note
By default, only basic unit tests are run. Add appropriate labels to enable an additional test coverage.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Triggering Code Rabbit AI Review
To trigger a code review from code rabbit, comment on a pull request with one of these commands:
See https://docs.coderabbit.ai/reference/review-commands for a full list of commands.
Pre-submit Checklist
Summary by CodeRabbit
Release Notes
New Features
no_weight_decay_embeddingsconfiguration parameter for Evo2 training recipes to control embedding weight decay behavior.Chores
Tests
✏️ Tip: You can customize this high-level summary in your review settings.