Return layernorm output in the gathered form #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Cui <[email protected]>
ksivaman
requested changes
Mar 4, 2024
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
ksivaman
reviewed
Mar 4, 2024
ksivaman
reviewed
Mar 4, 2024
Co-authored-by: Kirthi Shankar Sivamani <[email protected]> Signed-off-by: Chen Cui <[email protected]>
Co-authored-by: Kirthi Shankar Sivamani <[email protected]> Signed-off-by: Chen Cui <[email protected]>
ksivaman
reviewed
Mar 4, 2024
ksivaman
reviewed
Mar 4, 2024
ksivaman
reviewed
Mar 4, 2024
Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: Chen Cui <[email protected]>
|
/te-ci pytorch |
|
@cuichenx Could you fix the CI errors? |
Signed-off-by: Chen Cui <[email protected]>
|
/te-ci pytorch |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In layernorm linear,
return_layernorm_outputreturns the layernorm output in the ungathered format. For certain use cases, it is necessary to do a manual all gather (AG) outside of this function, leading to a duplicate AG that hurts performance. This PR adds an option to return layernorm output in the gathered form to prevent duplicate operation.