Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PyTorch] Fix incorrect variable name in LayerNormMLP backward #548

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

timmoon10
Copy link
Collaborator

@timmoon10 timmoon10 commented Dec 1, 2023

We mixed up a variable name in #545. This bug breaks wgrad fusion for LayerNormMLP.

@timmoon10 timmoon10 added the bug Something isn't working label Dec 1, 2023
@timmoon10 timmoon10 requested a review from ksivaman December 1, 2023 19:04
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

Copy link
Collaborator

@sudhakarsingh27 sudhakarsingh27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@timmoon10 timmoon10 merged commit 92c1e50 into NVIDIA:main Dec 1, 2023
9 checks passed
@timmoon10 timmoon10 deleted the zero-wgrad-bugfix branch December 1, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants