Fix incorrect dtype in LayerNormLinear #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Moon <[email protected]>
|
/te-ci pytorch |
timmoon10
added a commit
to timmoon10/TransformerEngine
that referenced
this pull request
Oct 19, 2023
|
I opened #485 to fix the errors in the fused attention test. |
ptrendx
approved these changes
Oct 19, 2023
|
/te-ci pytorch |
denera
pushed a commit
to denera/TransformerEngine
that referenced
this pull request
Oct 23, 2023
Signed-off-by: Tim Moon <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
ptrendx
pushed a commit
that referenced
this pull request
Oct 23, 2023
Signed-off-by: Tim Moon <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
mingxu1067
pushed a commit
to mingxu1067/TransformerEngine
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Tim Moon <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]> Signed-off-by: Ming Huang <[email protected]>
cyanguwa
pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Nov 13, 2023
Signed-off-by: Tim Moon <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]> Signed-off-by: Charlene Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've encountered a runtime error in LayerNormLinear when training LLaMa since RMSNorm is outputting to a buffer with an invalid dtype. In particular, we are not properly handling the case where the RMSNorm output is returned in bf16.
Note that LayerNormMLP handles this correctly:
TransformerEngine/transformer_engine/pytorch/module/layernorm_mlp.py
Line 146 in f456ba1