[JAX] Canonicalize the dtype for the better user experience #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reese Wang <[email protected]>
|
LGTM. Might have some conflicts with #472 |
mingxu1067
approved these changes
Oct 17, 2023
|
/te-ci jax |
nouiz
approved these changes
Oct 17, 2023
timmoon10
approved these changes
Oct 17, 2023
|
@timmoon10 All CIs are passed, please help merge it when you are available, thanks :) |
denera
pushed a commit
to denera/TransformerEngine
that referenced
this pull request
Oct 23, 2023
canonicalize the dtype for the better user experience Signed-off-by: Reese Wang <[email protected]>
mingxu1067
pushed a commit
to mingxu1067/TransformerEngine
that referenced
this pull request
Nov 3, 2023
canonicalize the dtype for the better user experience Signed-off-by: Reese Wang <[email protected]>
cyanguwa
pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Nov 13, 2023
canonicalize the dtype for the better user experience Signed-off-by: Reese Wang <[email protected]> Signed-off-by: Charlene Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
jax.dtypes.canonicalize_dtypeto wrap the dtype may from the users to ensure bothjnp.bfloat16and'bfloat16'work.