Fix CMakeList.txt to build as a sub-project #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmoon10
requested changes
Oct 17, 2023
niboshi
force-pushed
the
subproject-cmakelist
branch
2 times, most recently
from
e56d548 to
cd3ba3f
Compare
|
@timmoon10 Thanks. Signed my commit. |
Signed-off-by: niboshi <[email protected]>
niboshi
force-pushed
the
subproject-cmakelist
branch
from
cd3ba3f to
4be0ab1
Compare
|
I'm sorry, "Signed-off-by: " was missing in the commit message. I fixed it. |
|
/te-ci |
timmoon10
approved these changes
Oct 23, 2023
mingxu1067
pushed a commit
to mingxu1067/TransformerEngine
that referenced
this pull request
Nov 3, 2023
Signed-off-by: niboshi <[email protected]> Signed-off-by: Ming Huang <[email protected]>
cyanguwa
pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Nov 13, 2023
Signed-off-by: niboshi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered some issues while trying to integrate TransformerEngine as a subproject. These are the fixes.
CMAKE_SOURCE_DIRwithCMAKE_CURRENT_SOURCE_DIR.set( )instead oflist(APPEND ), as the latter resulted in command line like...;-threads 4in our build.