QuickGELU activation from HuggingFace/Transformers #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pytorch Signed-off-by: Alp Dener <[email protected]>
denera
force-pushed
the
hf-transformers-quick-gelu
branch
from
0c3e2cd to
643e867
Compare
Signed-off-by: Alp Dener <[email protected]>
|
/te-ci pytorch |
1 similar comment
|
/te-ci pytorch |
|
@denera Could you fix the merge conflict? |
ptrendx
reviewed
Feb 17, 2024
transformer_engine/common/include/transformer_engine/activation.h
Outdated
Show resolved
Hide resolved
ptrendx
approved these changes
Feb 17, 2024
Signed-off-by: Alp Dener <[email protected]>
Signed-off-by: Alp Dener <[email protected]>
|
/te-ci pytorch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approximates GELU(x) as
x * sigmoid(1.702 * x)(seeQuickGELUActivation()and paper).Locally passes regression test for LayerNormMLP linear accuracy.