[Paddle] Add TP overlap #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add @jeng1220 for vis. |
|
/te-ci |
Signed-off-by: Tian Zheng (Engrg-Hardware 1) <[email protected]>
Signed-off-by: Tian Zheng (Engrg-Hardware 1) <[email protected]>
Tom-Zheng
force-pushed
the
tizheng/add_tp_comm_async
branch
from
f8bb800 to
3301d4e
Compare
|
@jeng1220 Ready for review |
|
/te-ci paddle |
|
LGTM. @timmoon10 , |
|
/te-ci paddle |
|
The E RuntimeError: Cannot download https://dataset.bj.bcebos.com/mnist/train-images-idx3-ubyte.gz within retry limit 3
/usr/local/lib/python3.10/dist-packages/paddle/dataset/common.py:93: RuntimeError
=========================== short test summary info ============================
FAILED ../../examples/paddle/mnist/test_single_gpu_mnist.py::TestMNIST::test_te_bf16
FAILED ../../examples/paddle/mnist/test_single_gpu_mnist.py::TestMNIST::test_te_fp8
FAILED ../../examples/paddle/mnist/test_single_gpu_mnist.py::TestMNIST::test_te_fp8_calibration
======================== 3 failed in 364.53s (0:06:04) =========================@timmoon10 , |
timmoon10
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the overlap between TP backward allreduce kernel and GEMM kernel.