[JAX] Bug Fix: WeightInit with field #1361
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nightly CI failed last night with the error:
We should not use mutable default value (
praxis.base_layer.WeightInit
) forbias_init
in a dataclass as Python dataclasses don't allow mutable default values to prevent unexpected behavior due to shared state across instances.This PR fixes the issue by using the
default_factory
parameter of thefield()
function from thedataclasses
module to create a new object for each instance, avoiding the shared mutable state problem.Type of change
Changes
Checklist: