Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAX] Bug Fix: WeightInit with field #1361

Closed
wants to merge 3 commits into from

Conversation

phu0ngng
Copy link
Collaborator

@phu0ngng phu0ngng commented Dec 6, 2024

Description

Nightly CI failed last night with the error:

ValueError: mutable default <class 'praxis.base_layer.WeightInit'> for field bias_init is not allowed: use default_factory

We should not use mutable default value (praxis.base_layer.WeightInit) for bias_init in a dataclass as Python dataclasses don't allow mutable default values to prevent unexpected behavior due to shared state across instances.

This PR fixes the issue by using the default_factory parameter of the field() function from the dataclasses module to create a new object for each instance, avoiding the shared mutable state problem.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Phuong Nguyen <[email protected]>
@phu0ngng phu0ngng requested a review from zlsh80826 December 6, 2024 20:20
@phu0ngng
Copy link
Collaborator Author

phu0ngng commented Dec 6, 2024

/te-ci jax

@phu0ngng phu0ngng closed this Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant