Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Introduce NVSHMEM based communication API for pytorch #1346

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gdengk
Copy link

@gdengk gdengk commented Nov 22, 2024

Description

This PR uses pybinding to create NVSHMEM based APIs for pytorch.
Currently we have P2P and a draft implementation of CE based AG.

Still saw some device linking warnings to be cleaned up.

Need to provide NVSHMEM_HOME to compile the code and add NVSHMEM_HOME to LD_LIBRARY_PATH at runtime.

Fixes # (issue)

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant