[PyTorch] Improve CP P2P efficiency #1208
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The original implementation saves each attention layer's whole
K
,V
.Instead, we can discard used
K
,V
to ensure each GPU only holds the current and the nextK
,V
.Memory profiling results using the toy unit-test
Original:
This MR:
One can see that the unused
K
,V
are immediately released.Type of change