Fail early if output engine file path is unwritable in trtexec #4449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreMarieCurie
changed the title
PierreMarieCurie
changed the title
|
/blossom-ci |
poweiw
added
Module:Samples
|
/blossom-ci |
1 similar comment
|
/blossom-ci |
|
Hello @PierreMarieCurie thanks for your contribution! Can you target the main branch and have your commits rebase on that? |
PierreMarieCurie
force-pushed
the
release/10.10
branch
from
7010618 to
0cd927d
Compare
|
Hello @poweiw, thanks for your feedback. I've rebased my branch onto main and updated the PR to target it. Let me know if there's anything else you'd like adjusted. |
|
Thanks Pierre for the fast response! I lost my permission to trigger the pipeline but should be able to run next week. Will lyk with the pipeline results. |
|
/blossom-ci |
…X parsing Signed-off-by: Paul Pacheco <[email protected]>
PierreMarieCurie
force-pushed
the
release/10.10
branch
from
74de927 to
0392688
Compare
|
Hello @poweiw and @kevinch-nv, I messed up my rebase, sorry about that. The target branch was correct, but it was based on an old commit, so the pipeline failed. It should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi NVIDIA team,
This PR adds an early check in trtexec to ensure the --saveEngine path is writable before starting ONNX parsing. It avoids unnecessary compute when the path is invalid. This a proposition to solve issue #4448.
It has only been tested on the following environment: Ubuntu 24.04 running as a Dev Container within WSL2.
Thanks!