Skip to content

Conversation

nv-guomingz
Copy link
Collaborator

@nv-guomingz nv-guomingz commented Oct 11, 2025

Summary by CodeRabbit

  • Chores
    • Updated a core machine learning dependency to a newer minor version.
    • No user-facing functionality changes are expected from this update.
    • Anticipated improvements include enhanced stability and compatibility with recent environments.
    • Routine maintenance to keep the application aligned with upstream library updates.

Transformes 4.57.0 adds the official supporting for qwen3-next model.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

/bot [-h] ['run', 'kill', 'skip', 'reuse-pipeline'] ...

Provide a user friendly way for developers to interact with a Jenkins server.

Run /bot [-h|--help] to print this help message.

See details below for each supported subcommand.

run [--reuse-test (optional)pipeline-id --disable-fail-fast --skip-test --stage-list "A10-PyTorch-1, xxx" --gpu-type "A30, H100_PCIe" --test-backend "pytorch, cpp" --add-multi-gpu-test --only-multi-gpu-test --disable-multi-gpu-test --post-merge --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" --detailed-log --debug(experimental)]

Launch build/test pipelines. All previously running jobs will be killed.

--reuse-test (optional)pipeline-id (OPTIONAL) : Allow the new pipeline to reuse build artifacts and skip successful test stages from a specified pipeline or the last pipeline if no pipeline-id is indicated. If the Git commit ID has changed, this option will be always ignored. The DEFAULT behavior of the bot is to reuse build artifacts and successful test results from the last pipeline.

--disable-reuse-test (OPTIONAL) : Explicitly prevent the pipeline from reusing build artifacts and skipping successful test stages from a previous pipeline. Ensure that all builds and tests are run regardless of previous successes.

--disable-fail-fast (OPTIONAL) : Disable fail fast on build/tests/infra failures.

--skip-test (OPTIONAL) : Skip all test stages, but still run build stages, package stages and sanity check stages. Note: Does NOT update GitHub check status.

--stage-list "A10-PyTorch-1, xxx" (OPTIONAL) : Only run the specified test stages. Examples: "A10-PyTorch-1, xxx". Note: Does NOT update GitHub check status.

--gpu-type "A30, H100_PCIe" (OPTIONAL) : Only run the test stages on the specified GPU types. Examples: "A30, H100_PCIe". Note: Does NOT update GitHub check status.

--test-backend "pytorch, cpp" (OPTIONAL) : Skip test stages which don't match the specified backends. Only support [pytorch, cpp, tensorrt, triton]. Examples: "pytorch, cpp" (does not run test stages with tensorrt or triton backend). Note: Does NOT update GitHub pipeline status.

--only-multi-gpu-test (OPTIONAL) : Only run the multi-GPU tests. Note: Does NOT update GitHub check status.

--disable-multi-gpu-test (OPTIONAL) : Disable the multi-GPU tests. Note: Does NOT update GitHub check status.

--add-multi-gpu-test (OPTIONAL) : Force run the multi-GPU tests in addition to running L0 pre-merge pipeline.

--post-merge (OPTIONAL) : Run the L0 post-merge pipeline instead of the ordinary L0 pre-merge pipeline.

--extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx" (OPTIONAL) : Run the ordinary L0 pre-merge pipeline and specified test stages. Examples: --extra-stage "H100_PCIe-TensorRT-Post-Merge-1, xxx".

--detailed-log (OPTIONAL) : Enable flushing out all logs to the Jenkins console. This will significantly increase the log volume and may slow down the job.

--debug (OPTIONAL) : Experimental feature. Enable access to the CI container for debugging purpose. Note: Specify exactly one stage in the stage-list parameter to access the appropriate container environment. Note: Does NOT update GitHub check status.

For guidance on mapping tests to stage names, see docs/source/reference/ci-overview.md
and the scripts/test_to_stage_mapping.py helper.

kill

kill

Kill all running builds associated with pull request.

skip

skip --comment COMMENT

Skip testing for latest commit on pull request. --comment "Reason for skipping build/test" is required. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

reuse-pipeline

reuse-pipeline

Reuse a previous pipeline to validate current commit. This action will also kill all currently running builds associated with the pull request. IMPORTANT NOTE: This is dangerous since lack of user care and validation can cause top of tree to break.

@nv-guomingz
Copy link
Collaborator Author

/bot run

Copy link
Contributor

coderabbitai bot commented Oct 11, 2025

📝 Walkthrough

Walkthrough

Bumps the transformers dependency in requirements.txt from 4.56.0 to 4.57.0. No other files or configurations are changed.

Changes

Cohort / File(s) Summary
Dependency version update
requirements.txt
Update transformers version from 4.56.0 to 4.57.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description includes only a brief AI-generated summary and leaves both the “## Description” and “## Test Coverage” sections empty, which are required by the repository template. Required details explaining what was changed, why the upgrade is necessary, and how it is validated are missing, and placeholder comments remain in place. As a result, the description does not meet the structured template requirements. Please complete the “## Description” section with a concise explanation of the transformer version upgrade and its impact, and populate the “## Test Coverage” section with relevant tests that validate the change. Remove or replace any placeholder template comments so that all required headings contain meaningful content.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title follows the repository’s template and is formatted as “[None][chore] Summary” which clearly indicates the upgrade of the transformers dependency to version 4.57.0. It concisely conveys the primary change without extraneous details. Therefore, it meets the clarity and specificity requirements for pull request titles.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 84d2f12 and 2939043.

📒 Files selected for processing (1)
  • requirements.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check
🔇 Additional comments (1)
requirements.txt (1)

36-36: No transformers pin in constraints.txt; no action needed.
The constraints.txt file doesn’t contain a transformers entry, so the requirements.txt upgrade will apply as expected.

Likely an incorrect or invalid review comment.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21060 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21060 [ run ] completed with state FAILURE
/LLM/main/L0_MergeRequest_PR pipeline #15918 completed with status: 'FAILURE'

@nv-guomingz nv-guomingz force-pushed the user/guomingz/upgrade_transformes_package branch from 2939043 to 572aadd Compare October 11, 2025 05:45
@nv-guomingz nv-guomingz requested a review from a team as a code owner October 11, 2025 05:45
@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21071 [ run ] triggered by Bot

@nv-guomingz nv-guomingz force-pushed the user/guomingz/upgrade_transformes_package branch from 572aadd to 9098914 Compare October 11, 2025 06:58
@nv-guomingz nv-guomingz requested a review from a team as a code owner October 11, 2025 06:58
@tensorrt-cicd
Copy link
Collaborator

PR_Github #21071 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15926 completed with status: 'FAILURE'

@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21074 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21074 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #15928 completed with status: 'FAILURE'

@nv-guomingz nv-guomingz force-pushed the user/guomingz/upgrade_transformes_package branch 2 times, most recently from 43e8a91 to a8f1cf3 Compare October 13, 2025 14:16
@nv-guomingz nv-guomingz requested a review from a team as a code owner October 13, 2025 14:16
@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21226 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21226 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16019 completed with status: 'FAILURE'

@nv-guomingz nv-guomingz force-pushed the user/guomingz/upgrade_transformes_package branch from a8f1cf3 to 9df6f5a Compare October 13, 2025 23:59
@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21261 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21261 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16051 completed with status: 'FAILURE'

@nv-guomingz nv-guomingz force-pushed the user/guomingz/upgrade_transformes_package branch from 9df6f5a to 9f0ecbe Compare October 14, 2025 05:36
@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21309 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21309 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16086 completed with status: 'FAILURE'

@nv-guomingz nv-guomingz force-pushed the user/guomingz/upgrade_transformes_package branch from 9f0ecbe to d409559 Compare October 14, 2025 13:18
@nv-guomingz nv-guomingz force-pushed the user/guomingz/upgrade_transformes_package branch from d409559 to b695af7 Compare October 14, 2025 13:18
@nv-guomingz
Copy link
Collaborator Author

/bot run

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21361 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21361 [ run ] completed with state SUCCESS
/LLM/main/L0_MergeRequest_PR pipeline #16128 completed with status: 'FAILURE'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants