Skip to content

Conversation

lancelly
Copy link
Collaborator

@lancelly lancelly commented Oct 10, 2025

After internal cluster reboot, the tests seems allright. Unwaive the tests since this is likely a node issue that's been fixed by rebooting.

Summary by CodeRabbit

  • Tests
    • Re-enabled DeepSeekV3Lite multi-GPU accuracy tests by removing skip entries, restoring coverage for bfloat16 (4 GPUs) and NVFP4/MoE configurations.
    • Improves test coverage and validation without altering runtime behavior or public interfaces.
    • No functional changes to the application; affects only which tests are executed during integration runs.

Signed-off-by: Lanyu Liao <[email protected]>
@lancelly lancelly requested a review from a team as a code owner October 10, 2025 10:04
@lancelly
Copy link
Collaborator Author

/bot run --disable-fail-fast

Copy link
Contributor

coderabbitai bot commented Oct 10, 2025

📝 Walkthrough

Walkthrough

Removed two SKIP entries for DeepSeekV3Lite tests in tests/integration/test_lists/waives.txt, thereby unwaiving those tests. No code changes or public API modifications.

Changes

Cohort / File(s) Summary
Test waives update
tests/integration/test_lists/waives.txt
Removed two SKIP entries for DeepSeekV3Lite: bfloat16 4-GPU and nvfp4 4-GPU test cases in accuracy/test_llm_api_pytorch.py.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The PR description is a short informal note and does not follow the required repository template, as it lacks the @coderabbitai summary marker and the structured ## Description, ## Test Coverage, and ## PR Checklist sections. These missing sections mean critical details about the change rationale, how it is tested, and compliance with guidelines are not provided. Without this structure, reviewers may miss important context and test coverage information. Please update the description to use the repository’s template by adding the @coderabbitai summary marker, a ## Description section with the issue and solution, a ## Test Coverage section listing relevant tests, and a completed ## PR Checklist confirming guidelines compliance. This structured format ensures all necessary context, testing details, and review steps are clearly documented for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title follows the repository’s convention by including the NVBugs ID, a valid type tag, and a concise summary of the primary change to unwaive tests after node issues were resolved. It clearly reflects the main change without unnecessary detail or noise. Reviewers can quickly understand the intent and context from the title alone.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f720582 and b60ce92.

📒 Files selected for processing (1)
  • tests/integration/test_lists/waives.txt (0 hunks)
💤 Files with no reviewable changes (1)
  • tests/integration/test_lists/waives.txt
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Pre-commit Check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21025 [ run ] triggered by Bot

@tensorrt-cicd
Copy link
Collaborator

PR_Github #21025 [ run ] completed with state SUCCESS
/LLM/release-1.1/L0_MergeRequest_PR pipeline #78 completed with status: 'SUCCESS'

@chzblych chzblych merged commit 8f2e48a into NVIDIA:release/1.1 Oct 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants