Skip to content

[None][test] Add coverage for MsaSparseGqaFmha.forward - #17297

Draft
StanleySun639 wants to merge 1 commit into
NVIDIA:mainfrom
StanleySun639:gap-fixer/job-45-draft-43-check-22
Draft

[None][test] Add coverage for MsaSparseGqaFmha.forward#17297
StanleySun639 wants to merge 1 commit into
NVIDIA:mainfrom
StanleySun639:gap-fixer/job-45-draft-43-check-22

Conversation

@StanleySun639

Copy link
Copy Markdown
Collaborator

@coderabbitai summary

Description

Adds regression coverage for behavior introduced in 6af4e0be435a.

tests/unittest/_torch/attention/sparse/test_minimax_m3_msa_backend.py::test_msa_fmha_forward_falls_back_to_eager_plan_when_decode_plan_is_none verifies: MsaSparseGqaFmha.forward now uses a two-level fallback: if msa_decode_gqa_plan (or msa_decode_dense_plan) is None, it reads msa_eager_gqa_plan (or msa_eager_dense_plan) via getattr. Previously it used a ternary that could pass None to run_msa_paged_gqa.

Test Coverage

  • Test case: unittest/_torch/attention/sparse/test_minimax_m3_msa_backend.py::test_msa_fmha_forward_falls_back_to_eager_plan_when_decode_plan_is_none
  • Jenkins log: Jenkins #23SUCCESS

Gap Fixer Validation

  • Patch review: The revised patch correctly addresses the prior feedback by using a thin subclass with a custom init and @Property override to bypass the read-only 'attn' property, and the test directly exercises MsaSparseGqaFmha.forward with meaningful assertions on the fallback behavior.
  • Gap Fixer run: Job #45

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • If PR introduces API changes, an appropriate PR label is added - either api-compatible or api-breaking. For api-breaking, include BREAKING in the PR title.

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

Signed-off-by: Stanley Sun <stsun@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant