[None][fix] Honor MSA block-index strides for q_len <= 32 - #17285
Open
peihu-nv wants to merge 1 commit into
Open
[None][fix] Honor MSA block-index strides for q_len <= 32#17285peihu-nv wants to merge 1 commit into
peihu-nv wants to merge 1 commit into
Conversation
Signed-off-by: peihengh <259410613+peihu-nv@users.noreply.github.com>
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #63953 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #63953 [ run ] completed with state |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
MiniMax-M3's legacy MSA sparse-attention path for
q_len <= 32can receivekv_block_indexesas a non-contiguous, head-major tensor view. The SM100kernel treated the underlying pointer as a contiguous
[query, KV head, top-k]allocation, which could select incorrect KV pagesand produce incorrect or non-finite attention output.
This change passes the tensor's query, KV-head, and top-k strides through the
existing MSA native interface and uses them for every sparse block-index load.
It also updates the bounds-check extent for the strided view. The attention
algorithm is unchanged, and no materialization, new kernel, or additional
buffer is introduced. The feature branch's existing downstream MSA patch and
TensorRT-LLM-collected test carry the change until it lands in MSA directly.
Test Coverage
selectors are finite and bit-identical for
q_len1 and 5 with one and twoKV splits (4/4 combinations passed).
all ten 1,800-second, default-sampling profiles completed validly with zero
serving errors and no non-finite marker.
23.361 us for the compact reference; avoiding materialization saved
11.161 us in the selector-plus-consumer path.
the six patched native-source hashes match the E2E-tested implementation.
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.