[https://nvbugs/6523820][fix] Waive NCCL-EP dispatch-only CUDA graph replay test - #16959
Conversation
fe6e8a8 to
00c9826
Compare
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe NCCL-EP CUDA-graph replay routing test is marked with ChangesNCCL-EP test waiver
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
PR_Github #62235 [ run ] triggered by Bot. Commit: |
|
PR_Github #62235 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #62295 [ run ] triggered by Bot. Commit: |
|
PR_Github #62295 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #62313 [ run ] triggered by Bot. Commit: |
|
PR_Github #62313 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #62769 [ run ] triggered by Bot. Commit: |
|
PR_Github #62769 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #62899 [ run ] triggered by Bot. Commit: |
|
PR_Github #62899 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #63034 [ run ] triggered by Bot. Commit: |
|
PR_Github #63034 [ run ] completed with state
|
00c9826 to
bd6aa12
Compare
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #63108 [ run ] triggered by Bot. Commit: |
|
PR_Github #63108 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #63123 [ run ] triggered by Bot. Commit: |
|
PR_Github #63123 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #63454 [ run ] triggered by Bot. Commit: |
|
PR_Github #63454 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #63475 [ run ] triggered by Bot. Commit: |
|
PR_Github #63475 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #63547 [ run ] triggered by Bot. Commit: |
|
PR_Github #63547 [ run ] completed with state
|
|
/bot run --extra-stage "GB200-4_GPUs-PyTorch-4" |
|
PR_Github #64061 [ run ] triggered by Bot. Commit: |
|
PR_Github #64061 [ run ] completed with state |
|
/bot run --disable-reuse-test --stage-list "GB200-4_GPUs-PyTorch-1, GB200-4_GPUs-PyTorch-2, GB200-4_GPUs-PyTorch-3, GB200-4_GPUs-PyTorch-4, GB200-4_GPUs-PyTorch-5" |
|
PR_Github #64094 [ run ] triggered by Bot. Commit: |
Signed-off-by: Ludwig Schneider <lschneider@nvidia.com>
bd6aa12 to
ee8e18e
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/bot run --stage-list "GB200-4_GPUs-PyTorch-*" |
|
PR_Github #64347 [ run ] triggered by Bot. Commit: |
|
PR_Github #64094 [ run ] completed with state |
|
PR_Github #64347 [ run ] completed with state
|
Dev Engineer Review
test_nccl_ep_cuda_graph_replay_uses_updated_routingwith@pytest.mark.skip.git diff --check, Ruff, and Ruff-format pre-commit hooks.QA Engineer Review
tests/unittest/_torch/modules/moe/test_moe_comm.py::test_nccl_ep_cuda_graph_replay_uses_updated_routing.tests/integration/test_lists/,test-db/, orqa/files changed.Description
Temporarily waive TestMoEComm.test_nccl_ep_cuda_graph_replay_uses_updated_routing.
The test captures and replays an NCCL-EP low-latency dispatch-only CUDA graph while changing routing between replays. This exposes an NCCL-EP internal ping-pong-buffer replay issue and is tracked to be fix soon in NCCL-EP.
This does not affect TRT-LLM’s standard CUDA-graph execution path: TRT-LLM captures the complete MoE forward path, including both NCCL-EP dispatch and combine. Those paired operations advance the internal buffer state together.
The regression test remains in-tree and will be re-enabled after updating to an NCCL-EP release containing the fix.
Test Coverage
PR Checklist