nano v3 disable piecewise#16193
Open
tcherckez-nvidia wants to merge 1 commit into
Open
Conversation
Contributor
📝 WalkthroughWalkthroughThis PR disables ChangesConfig and Test Waiver Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…on Nano V3 Under enable_chunked_prefill=true, Nemotron Nano V3 (hybrid Mamba2+MoE) produces device-side NaNs during piecewise CUDA-graph replay for small, heavily-padded token buckets, tripping the FlashInfer sampler's NaN assert on the first generation step. Disable piecewise CUDA-graph capture to avoid the faulty replay path while the underlying issue is investigated. Un-waive the TestNemotronNanoV3 accuracy variants (bf16/fp8 verified passing; nvfp4 to be confirmed in Blackwell CI). Signed-off-by: tcherckez-nvidia <127761168+tcherckez-nvidia@users.noreply.github.com>
e412978 to
a699789
Compare
Collaborator
Author
|
/bot run |
Collaborator
|
PR_Github #58473 [ run ] triggered by Bot. Commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on Nano V3
Under enable_chunked_prefill=true, Nemotron Nano V3 (hybrid Mamba2+MoE) produces device-side NaNs during piecewise CUDA-graph replay for small, heavily-padded token buckets, tripping the FlashInfer sampler's NaN assert on the first generation step. Disable piecewise CUDA-graph capture to avoid the faulty replay path while the underlying issue is investigated.
Un-waive the TestNemotronNanoV3 accuracy variants (bf16/fp8 verified passing; nvfp4 to be confirmed in Blackwell CI).
Summary by CodeRabbit
Bug Fixes
Chores
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.