[None][feat] Integrate KVCMv2 commit_min_snapshot in runtime#16185
Draft
jiaganc wants to merge 2 commits into
Draft
[None][feat] Integrate KVCMv2 commit_min_snapshot in runtime#16185jiaganc wants to merge 2 commits into
commit_min_snapshot in runtime#16185jiaganc wants to merge 2 commits into
Conversation
Signed-off-by: Jiagan Cheng <jiaganc@nvidia.com>
Signed-off-by: Jiagan Cheng <jiaganc@nvidia.com>
commit_min_snapshot in runtime
Collaborator
Author
|
This PR depends on #15752 and should wait for it to be merged first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
Description
Integrate
commit_min_snapshotsupport for SSM reuse from #15752 and connect it to the KV cache manager V2 block-reuse policies.The cache manager now commits a minimal SSM snapshot when block reuse is enabled for policies other than
all_reusable, propagates partial-reuse configuration, and handles the final context commit path. The change includes coverage for SSM/SWA reuse, partial-page commits, cache statistics, DeepSeek V4 sparse cache configuration, and V2 reuse-policy selection.Test Coverage
python3 -m py_compilepassed for the directly modified Python implementation and test files.pytestinstalled.PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
If PR introduces API changes, an appropriate PR label is added - either
api-compatibleorapi-breaking. Forapi-breaking, includeBREAKINGin the PR title.Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.