Skip to content

[https://nvbugs/6337235][test] Fix MX/GMS model loader fixtures#15471

Draft
chienchunhung wants to merge 1 commit into
NVIDIA:mainfrom
chienchunhung:codex/nvbug-6337235-model-loader-test-fixtures
Draft

[https://nvbugs/6337235][test] Fix MX/GMS model loader fixtures#15471
chienchunhung wants to merge 1 commit into
NVIDIA:mainfrom
chienchunhung:codex/nvbug-6337235-model-loader-test-fixtures

Conversation

@chienchunhung

@chienchunhung chienchunhung commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix stale MX/GMS ModelLoader unit-test fixtures exposed by the expanded L0 unit-test coverage.

ModelLoader.load() now builds a SourceIdentity for GMS and MX paths. These branch-focused tests stub _load_and_validate_config() with a lightweight SimpleNamespace, so the real fingerprint builder can fail before the tests reach the GMS/MX behavior they are meant to cover. This PR stubs SourceIdentity.from_model_config() in those tests with a fixed real SourceIdentity, and makes the GMS RO backend return the same identity so the strict RO gate still executes successfully.

Reference: https://nvbugs/6337235

Test Coverage

  • PYTHONPYCACHEPREFIX=/private/tmp/trtllm_pycache python3 -m py_compile tests/unittest/_torch/pyexecutor/test_model_loader_gms.py tests/unittest/_torch/pyexecutor/test_model_loader_mx.py
  • git diff --check
  • Commit hooks passed for the touched files. Skipped waive list check and validate-test-lists locally because they crash under this machine's Python 3.9 while parsing Python 3.10 union annotations in scripts/check_test_list.py.

Note: focused pytest was not runnable in this local environment because pytest is not installed for the system Python.

Stub SourceIdentity construction in the MX/GMS ModelLoader branch tests so the tests keep focusing on branch behavior while dedicated source-identity tests cover fingerprint compatibility.

NVBUG 6337235

Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
@chienchunhung chienchunhung changed the title [NVBUG-6337235][test] Fix MX/GMS model loader fixtures [https://nvbugs/6337235][test] Fix MX/GMS model loader fixtures Jun 18, 2026
@chienchunhung

Copy link
Copy Markdown
Collaborator Author

/bot run --disable-fail-fast

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54892 [ run ] triggered by Bot. Commit: 9688833 Link to invocation

@tensorrt-cicd

Copy link
Copy Markdown
Collaborator

PR_Github #54892 [ run ] completed with state FAILURE. Commit: 9688833
/LLM/main/L0_MergeRequest_PR pipeline #43896 completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

CI Agent Failure Analysis

Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants