[https://nvbugs/6337235][test] Fix MX/GMS model loader fixtures#15471
Draft
chienchunhung wants to merge 1 commit into
Draft
[https://nvbugs/6337235][test] Fix MX/GMS model loader fixtures#15471chienchunhung wants to merge 1 commit into
chienchunhung wants to merge 1 commit into
Conversation
Stub SourceIdentity construction in the MX/GMS ModelLoader branch tests so the tests keep focusing on branch behavior while dedicated source-identity tests cover fingerprint compatibility. NVBUG 6337235 Signed-off-by: Chien-Chun Hung <2679986+chienchunhung@users.noreply.github.com>
Collaborator
Author
|
/bot run --disable-fail-fast |
Collaborator
|
PR_Github #54892 [ run ] triggered by Bot. Commit: |
Collaborator
|
PR_Github #54892 [ run ] completed with state
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix stale MX/GMS
ModelLoaderunit-test fixtures exposed by the expanded L0 unit-test coverage.ModelLoader.load()now builds aSourceIdentityfor GMS and MX paths. These branch-focused tests stub_load_and_validate_config()with a lightweightSimpleNamespace, so the real fingerprint builder can fail before the tests reach the GMS/MX behavior they are meant to cover. This PR stubsSourceIdentity.from_model_config()in those tests with a fixed realSourceIdentity, and makes the GMS RO backend return the same identity so the strict RO gate still executes successfully.Reference: https://nvbugs/6337235
Test Coverage
PYTHONPYCACHEPREFIX=/private/tmp/trtllm_pycache python3 -m py_compile tests/unittest/_torch/pyexecutor/test_model_loader_gms.py tests/unittest/_torch/pyexecutor/test_model_loader_mx.pygit diff --checkwaive list checkandvalidate-test-listslocally because they crash under this machine's Python 3.9 while parsing Python 3.10 union annotations inscripts/check_test_list.py.Note: focused
pytestwas not runnable in this local environment becausepytestis not installed for the system Python.