Add Stable Diffusion demo #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parthchadha
reviewed
Aug 14, 2024
parthchadha
reviewed
Aug 14, 2024
tripy/examples/diffusion/model.py
Outdated
| - Paper: https://arxiv.org/abs/1706.03762v7 | ||
| """ | ||
|
|
||
| if is_causal: # this path is not called in demoDiffusion |
There was a problem hiding this comment.
Can we drop this if it's not called?
There was a problem hiding this comment.
I have left it for now in case we want to add it as part of the API somewhere
tripy/examples/diffusion/model.py
Outdated
| return tp.cast(tp.softmax((qk + attn_mask) if attn_mask is not None else qk, -1), query.dtype) @ value | ||
|
|
||
|
|
||
| def sequential(input: tp.Tensor, ll: List[Callable[[tp.Tensor], tp.Tensor]]): |
There was a problem hiding this comment.
I think it's worth making this part of the API, similar to torch.nn.Sequential.
There was a problem hiding this comment.
This is being done here: #321
akhilg-nv
force-pushed
the
dev-akhilg-demo-diffusion
branch
3 times, most recently
from
0d3c2cd to
c7c81bd
Compare
akhilg-nv
force-pushed
the
dev-akhilg-demo-diffusion
branch
from
c7c81bd to
5142a42
Compare
akhilg-nv
force-pushed
the
dev-akhilg-demo-diffusion
branch
from
5142a42 to
d9dd478
Compare
Signed-off-by: Akhil Goel <[email protected]>
Signed-off-by: Akhil Goel <[email protected]>
Root cause: Index for denoising timesteps were reversed while refactoring. Signed-off-by: Akhil Goel <[email protected]>
Signed-off-by: Akhil Goel <[email protected]>
Signed-off-by: Akhil Goel <[email protected]>
Signed-off-by: Akhil Goel <[email protected]>
Signed-off-by: Akhil Goel <[email protected]>
Remove lazy mode evaluation in the denoising loop.
akhilg-nv
force-pushed
the
dev-akhilg-demo-diffusion
branch
from
d9dd478 to
75efd7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup for Tripy inference, torch inference pipeline, and accuracy test are still WIP. README is currently minimal as well.