feat(policy): preserve exact MCP revision allowlists - #3027
Open
shiju-nv wants to merge 3 commits into
Open
Conversation
shiju-nv
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
August 31, 2026 08:34
Signed-off-by: Shiju <shiju@nvidia.com>
Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
force-pushed
the
feat/2954-mcp-revision-allowlists
branch
from
September 2, 2026 18:10
3ffdf2e to
cbc0b20
Compare
Signed-off-by: Shiju <shiju@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenShell cannot apply revision-specific MCP rules unless each inspected endpoint carries the exact revisions it allows. This PR adds a nonempty
mcp.versionsallowlist and preserves its validated value through provider profiles, policy storage and composition, merge checks, hashing, history listing, sandbox configuration, and SDK conversions. Omitted lists become exactly["2025-11-25"], explicit lists are sorted, and invalid or duplicate entries are rejected so a later registry change cannot widen a stored policy.Related Issue
Closes #2954.
Part of #2174.
Changes
2025-03-26,2025-06-18, and2025-11-25, including the batch-shape facts needed by runtime enforcement. Add an exactmcp.versionsallowlist to protobuf, provider profiles, policy YAML, and the Go SDK. Empty lists, duplicates, padded strings, unsupported dates,draft, andlatestare rejected. An omitted allowlist materializes as exactly["2025-11-25"]; the stored default never follows the newest registry entry.Testing
mise run pre-commitpassesChecklist