Skip to content

chore(deps): remove legacy rustls webpki path - #3013

Merged
elezar merged 1 commit into
mainfrom
no-issue-dependabot-rustls-webpki/elezar
Sep 1, 2026
Merged

chore(deps): remove legacy rustls webpki path#3013
elezar merged 1 commit into
mainfrom
no-issue-dependabot-rustls-webpki/elezar

Conversation

@elezar

@elezar elezar commented Aug 28, 2026

Copy link
Copy Markdown
Member

Summary

Switch AWS SDK crates to default-https-client so the dependency graph no longer enables the legacy Hyper 0.14 / rustls 0.21 TLS stack. This removes the vulnerable rustls-webpki 0.101.7 instance flagged by Dependabot alert 6.

Related Issue

No public issue: addresses GitHub Dependabot security alert 6 (rustls-webpki GHSA-82j2-j2ch-gfr8).

Changes

  • Replace AWS SDK rustls feature usage with default-https-client.
  • Regenerate Cargo.lock, removing legacy hyper-rustls 0.24.2, rustls 0.21.12, tokio-rustls 0.24.1, sct, and rustls-webpki 0.101.7.

Testing

  • mise run pre-commit passes
  • dev-openshell shell mise run pre-commit attempted; failed in existing helm:lint because chart metadata is missing postgresql
  • /home/elezar/.cargo/bin/cargo check -p openshell-server
  • /home/elezar/.cargo/bin/cargo tree -i rustls-webpki@0.101.7 no longer finds the package
  • Unit tests added/updated
  • E2E tests added/updated (if applicable)

Checklist

  • Follows Conventional Commits
  • Commits are signed off (DCO)

@elezar
elezar requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners August 28, 2026 14:49
@elezar elezar added the test:e2e Requires end-to-end coverage label Aug 28, 2026
@github-actions

Copy link
Copy Markdown

Label test:e2e applied for a795360. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar
elezar force-pushed the no-issue-dependabot-rustls-webpki/elezar branch from a795360 to 93eba30 Compare September 1, 2026 08:52
@elezar
elezar added this pull request to the merge queue Sep 1, 2026
@elezar elezar mentioned this pull request Sep 1, 2026
5 tasks
Merged via the queue into main with commit 8a13bc1 Sep 1, 2026
73 checks passed
@elezar
elezar deleted the no-issue-dependabot-rustls-webpki/elezar branch September 1, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test:e2e Requires end-to-end coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants