perf(supervisor-network): avoid reparsing native policy input - #2654
Open
shiju-nv wants to merge 1 commit into
Open
perf(supervisor-network): avoid reparsing native policy input#2654shiju-nv wants to merge 1 commit into
shiju-nv wants to merge 1 commit into
Conversation
Convert the existing Serde JSON policy input directly into Regorus. Preserve conversion errors while avoiding JSON string allocation and parsing. Signed-off-by: Shiju <shiju@nvidia.com>
shiju-nv
requested review from
a team,
derekwaynecarr,
maxamillion and
mrunalp
as code owners
August 7, 2026 15:53
Collaborator
|
Do we want to audit and address similar call sites in opa.rs as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenShell currently builds a
serde_json::Value, serializes it to JSON text, and asks Regorus to parse that text into its own value representation. Convert the existingserde_json::Valuedirectly intoregorus::Value, then pass it toEngine::set_input. This removes the intermediate string and JSON text parse while continuing to return conversion errors before policy evaluation.Changes
input_jsontoinput.serde_json::Valuedirectly intoregorus::Valuewithout serializing and reparsing JSON text.From<serde_json::Value>conversion to map failures toUndefined.Testing
mise run pre-commitpassesChecklist