fix(e2e): use isolated gateway state for inference switch - #9216
Conversation
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe gateway fixture now accepts an explicit home directory for PID discovery and resolver setup. End-to-end tests pass isolated home directories, mock process inspection, and clean up the resulting directory trees. ChangesGateway home directory propagation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This localized E2E fixture change selects gateway state from the isolated test home and preserves existing defaults for other callers; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 87a58c4 in the TypeScript / code-coverage/cliThe overall coverage in commit 87a58c4 in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 2 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: Manual-only E2E: This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
Summary
The OpenClaw inference-switch E2E target installed OpenShell under an isolated home but looked for managed gateway state under the test process's ambient home. Pass the target home to the existing owned gateway-state verifier so the target uses its recorded Docker-driver gateway instead of falling through to unavailable user-systemd services.
Failure evidence: E2E run 31895698451, job 95038810397. Ownership was claimed on #9166 before implementation: #9166 (comment)
Related Issue
Related to #9166.
Changes
Type of Change
Quality Gates
d47cc72d8passed all nine required categories with no finding; the three reviewed file blobs are unchanged at latest PR commit87a58c462.Documentation Writer Review
no-docs-needed87a58c462, the complete diff against basede29c02a1changes only internal E2E fixtures and tests. It passes the isolated test home to the existing owned gateway-state verifier and stores verifier artifacts under that home; it does not change supported product behavior or a user-visible surface./root/openclaw_docs_review)DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailable87a58c462,npx vitest run --project e2e-support test/e2e/support/compatible-anthropic-switch.test.ts: 11 passed, 1 Linux-only skipped on macOS.npm run validate:pr, CLI typecheck, Oxfmt, Oxlint, repository checks, semantic-phase coverage, size/conditional checks, andgit diff --checkpassed after merging mainde29c02a1.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Senthil Ravichandran senthilr@nvidia.com
Summary by CodeRabbit