test(e2e): accept current OpenClaw idle status

[apurvvkumaria]

Summary

The OpenClaw live E2E jobs received the expected reply and then reported gateway connected | idle, but the launch helper still required the obsolete exact line connected | idle. This change aligns both live callers with the current exact terminal line while preserving reply-before-idle ordering.

Changes

• Require gateway connected | idle after the exact OpenClaw reply in both live launch paths.
• Extend support coverage to reject an idle line before the reply and a busy line after the reply.
• Close the detection gap that let the support test validate an outdated terminal line.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: This changes internal E2E terminal-line assertions only; commands, configuration, defaults, supported workflows, and product behavior are unchanged.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: Commit 4a70d0d9d changes only internal E2E expectations and regression coverage. No documentation contains the affected terminal strings, and no user-facing behavior changes.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result or justification: npx vitest run test/e2e/support/launch-agent-turn.test.ts passed 6 tests with 1 platform-specific skip; npm run test:titles:check passed.
• Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result: Not applicable; the change is limited to two exact live-call expectations and their focused support test.
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Apurv Kumaria akumaria@nvidia.com

Summary by CodeRabbit

• Tests
  • Updated end-to-end readiness checks to expect the clearer “gateway connected | idle” status.
  • Strengthened launch-turn validation to ensure exit commands are sent only after the expected reply and idle signal.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 05fe5fdc-eabe-4d21-a40c-c8d76ddd76e8

📥 Commits

Reviewing files that changed from the base of the PR and between 0caec10 and 4a70d0d.

📒 Files selected for processing (3)

• test/e2e/live/full-e2e.test.ts
• test/e2e/live/launch-readiness-lease-acceptance.test.ts
• test/e2e/support/launch-agent-turn.test.ts

---

📝 Walkthrough

Walkthrough

The E2E readiness tests now expect "gateway connected | idle". The launch-turn fixture also verifies readiness timing and rejects /exit while the TUI is busy.

Changes

Readiness text alignment

Layer / File(s)	Summary
Launch-turn readiness sequence test/e2e/support/launch-agent-turn.test.ts	The fixture validates gateway idle signals before and after replies. It rejects premature /exit during the busy state.
E2E readiness expectations test/e2e/live/full-e2e.test.ts, test/e2e/live/launch-readiness-lease-acceptance.test.ts	The recovery and lease acceptance tests expect `"gateway connected

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 4a70d

This PR updates internal E2E terminal-line expectations and focused regression coverage; no actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

• NVIDIA/NemoClaw#8951: Introduces the launch-readiness lease tests and fixture updated here.
• NVIDIA/NemoClaw#9053: Introduces the readiness tests and support fixture updated here.

Suggested labels: v0.0.109

Suggested reviewers: prekshivyas, sandl99, cv

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the E2E update to accept OpenClaw's current idle status.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-openclaw-launch-ready-state

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 4a70d0d in the codex/fix-openclaw-l... branch remains at 96%, unchanged from commit 0caec10 in the main branch.

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Failed

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

2 semantic terminology decisions

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

• established — exact reply at test/e2e/support/launch-agent-turn.test.ts:124: Keep `exact reply` for this PTY response contract.
• justified — post-reply at test/e2e/support/launch-agent-turn.test.ts:124: Keep `post-reply` because it distinguishes the ordering constraint that the test enforces.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite for the commit under review.

Recommended E2E: None

Manual-only E2E: cloud-onboard, security-posture, cloud-inference
The manual PR workflow does not run these selectors for the commit under review. Run them from reviewed code on main.

2 optional E2E recommendations

• ubuntu-repo-cloud-openclaw
• full-e2e

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.