refactor(e2e): consolidate more retained profile jobs - #8966
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 47640b4 in the TypeScript / code-coverage/cliThe overall coverage in commit 47640b4 in the Show a code coverage summary of the most impacted files.
Updated |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe PR removes three standalone E2E jobs and routes their targets through catalogue-managed workflow matrices. It narrows related validators and updates boundary tests, documentation, source-shape exceptions, and watch-trigger expectations. ChangesE2E target catalogue and planning
Workflow execution and validation
Contract coverage alignment
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to The PR consolidates retained E2E jobs while preserving their documented execution and evidence contracts; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
3 terminology differences from the second opinionAdvisory only. These are normalized differences from the primary terminology receipt.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 3 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: Manual-only E2E: 3 optional E2E recommendations
This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Summary
Three E2E targets repeated an execution profile in dedicated workflow jobs. This change moves them into the existing target catalogue and reusable profile while preserving their runner, credential, setup, timeout, environment, and evidence contracts.
Related Issue
Refs #7912
Changes
hermes-slackandsandbox-operationsinto the NVIDIA inference profile.openclaw-inference-switchinto the standard profile. Its one Anthropic-compatible mode is now target environment instead of a one-row job matrix.skill-agentdedicated because its explicit artifact allowlist is a distinct evidence boundary.Type of Change
Quality Gates
Documentation Writer Review
docs-updatedtest/e2e/README.mddocuments the single target catalogue, its three credential-profile matrices, and the criteria for retained workflow jobs. The reviewer verified the follow-up against.github/workflows/e2e-standard-profile.yamlandtools/e2e/standard-profile-workflow-boundary.mts. No public documentation changes are needed.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm run test:projects:check,npm run checks:repository, Markdown lint, Biome lint, andgit diff --checkpassed. The CLI build and type check passed. Normal pre-commit, commit-msg, and pre-push hooks passed.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: Not run locally by maintainer direction; GitHub CI owns the broad suite.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Documentation
Tests
Chores