test(e2e): cover shared job selector mapping

[cv]

Summary

#8961 replaced dedicated E2E jobs with catalogue and profile execution, but its selector test covered only an identity target-to-job mapping. This follow-up verifies that vllm-docker-storage remains target-based during selector evaluation and schedules the shared-e2e workflow job with its integration test row.

Related Issue

Refs #8961
Refs #7912

Changes

• Add one focused E2E-support assertion for vllm-docker-storage.
• Verify that selector evaluation returns the target ID and planning schedules shared-e2e with the exact integration test row.
• Add no abstraction, configuration, fallback, migration, or compatibility path.

Type of Change

• Code change (feature, bug fix, or refactor)
• Code change with doc updates
• Doc only (prose changes, no code sample modifications)
• Doc only (includes code sample changes)

Quality Gates

• Tests added or updated for changed behavior
• Existing tests cover changed behavior — justification:
• Tests not applicable — justification:
• Docs updated for user-facing behavior changes
• Docs not applicable — justification: This change adds regression coverage for existing behavior introduced and documented by refactor(e2e): consolidate retained profile jobs #8961; no product behavior or documented surface changes.
• Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
• Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
• Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

• Documentation writer subagent reviewed the completed changes
• Result: no-docs-needed
• Evidence: Test-only regression coverage for existing selector-to-shared-e2e planning behavior; no behavior or documented surface changed.
• Agent: Codex Desktop

DGX Station Hardware Evidence

• Tested on DGX Station
• Tested commit:
• Station profile/scenario:
• Result:
• Supporting evidence:

Verification

• PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
• Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
• Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project e2e-support test/e2e/support/e2e-workflow.test.ts --reporter=dot passed 34 tests.
• Applicable broad gate passed — Not applicable to this focused test-only change; GitHub CI owns the broad suite.
• Quality Gates section completed with required justifications or waivers
• No secrets, API keys, or credentials committed
• npm run docs builds without warnings (doc changes only)
• Doc pages follow the style guide (doc changes only)
• New doc pages include SPDX header and frontmatter (new pages only)

---

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

• Tests
  • Added end-to-end coverage for the vllm-docker-storage workflow.
  • Verifies target selection, job mapping, integration test matrix generation, and shared job selection.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: c5c1065c-1584-40a3-bc0e-9a4c8852dabd

📥 Commits

Reviewing files that changed from the base of the PR and between ceea7dd and 75acbb7.

📒 Files selected for processing (1)

• test/e2e/support/e2e-workflow.test.ts

---

📝 Walkthrough

Walkthrough

Adds an end-to-end test for the vllm-docker-storage target. The test validates dispatch selection, free-standing job mapping, integration test matrix generation, project assignment, and shared-e2e selection.

Changes

Workflow coverage

Layer / File(s)	Summary
Dispatch and planning assertions test/e2e/support/e2e-workflow.test.ts	Adds coverage for vllm-docker-storage selector validity, free-standing job mapping, integration test file and project, and shared-e2e selection.

Estimated code review effort: 2 (Simple) | ~10 minutes

Mergeability Score: ⚪ Minimal · up to 75acb

This localized test-only change adds regression coverage for shared job selector mapping without changing product behavior or runtime configuration. No actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

• NVIDIA/NemoClaw#8915: Introduces the catalogue and planner workflow tests extended by this change.

Suggested reviewers: aasthajh

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the added E2E coverage for shared job selector mapping.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/cover-shared-e2e-selector-mapping

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 75acbb7 in the codex/cover-shared-e... branch remains at 96%, unchanged from commit 735e88e in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 75acbb7 in the codex/cover-shared-e... branch remains at 82%, unchanged from commit 305bb4c in the main branch.

Show a code coverage summary of the most impacted files.

File	main 305bb4c	codex/cover-shared-e... 75acbb7	+/-
src/lib/actions...ocker-health.ts	80%	65%	-15%
src/lib/onboard...der/snapshot.ts	83%	75%	-8%
src/lib/onboard...press-resume.ts	82%	78%	-4%
src/lib/securit...ntial-filter.ts	92%	89%	-3%
src/lib/inferen...ollama/proxy.ts	35%	34%	-1%
src/lib/state/o...d-checkpoint.ts	87%	90%	+3%
src/lib/trace.ts	90%	94%	+4%
src/lib/cua/run...ime-manifest.ts	84%	91%	+7%
src/lib/cua/contract.ts	80%	87%	+7%
src/lib/cua/bounded-file.ts	84%	94%	+10%

---

_{Updated August 13, 2026 08:21 UTC}

[github-actions]

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

• GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
• Model comparison: normalized findings match; normalized terminology decisions differ; normalized E2E selections match; severity counts match.

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

1 semantic terminology decision

Terminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.

• established — credential-free at test/e2e/support/e2e-workflow.test.ts:633: Retain `credential-free`; the controlled word list and existing workflow and test sources use this term with the same meaning.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite for the commit under review.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.