fix(cli): use provider-neutral onboarding copy - #8867
Conversation
Signed-off-by: Yimo Jiang <yimoj@nvidia.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe workspace documentation now describes deferred creation of memory files and validates workspace inventory consistency. Onboarding progress text now uses provider-neutral wording, with regression coverage for resumed Ollama selection. ChangesWorkspace documentation
Onboarding progress copy
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to The PR updates onboarding wording and workspace documentation with targeted validation; no actionable merge-blocking risk remains at the current head beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit cdd1cab in the TypeScript / code-coverage/cliThe overall coverage in commit cdd1cab in the Show a code coverage summary of the most impacted files.
Updated |
|
🌿 Preview your docs: https://nvidia-preview-pr-8867.docs.buildwithfern.com/nemoclaw |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/onboard/machine/progress.test.ts`:
- Around line 39-44: The test title claims resume-flow coverage, but it only
checks provider-selection metadata. Either extend the test to exercise the
resumed flow through skippedStepMessage, including its rendered title, or rename
the test to describe the provider-selection metadata returned by
getOnboardProgressStep.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 16237997-563c-4be1-ad9e-e3acc0b3b4bb
📒 Files selected for processing (3)
docs/manage-sandboxes/workspace-files.mdxsrc/lib/onboard/machine/definition.tssrc/lib/onboard/machine/progress.test.ts
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
2 terminology differences from the second opinionAdvisory only. These are normalized differences from the primary terminology receipt.
1 additional E2E selection from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 2 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: None Manual-only E2E: 1 optional E2E recommendation
1 warning · 0 suggestionsWarningsWarnings do not block.
|
Signed-off-by: Yimo Jiang <yimoj@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
The branch is now synchronized with current This incorporates the upstream test-harness repair associated with the previous gateway-helper failures. On the synchronized branch, the three formerly failing gateway suites pass with 51 tests passed and one intentionally skipped. The PR's own effective change remains three files with 25 additions and 8 deletions. Scoped security review: the production change replaces one static progress label with provider-neutral text. It does not change input handling, command construction, credentials, network policy, filesystem access, privilege boundaries, or dependencies. The documentation accurately describes OpenClaw's first-use memory-file behavior, and the regression exercises the resumed Ollama path. Local validation:
Fresh repository checks, the documentation receipt, and human review remain required. |
cv
left a comment
There was a problem hiding this comment.
docs/manage-sandboxes/workspace-files.mdx:126 says each per-agent workspace has the same Markdown file structure as the default workspace, but it names only SOUL.md, USER.md, IDENTITY.md, and AGENTS.md. At this commit, scripts/nemoclaw-start.sh:4554 also seeds TOOLS.md and HEARTBEAT.md, and test/nemoclaw-start.test.ts:2446-2477 verifies that six-file set. The changed documentation therefore leaves the workspace-layout fix incomplete and can lead operators to conclude that tool and heartbeat configuration files are absent. Add TOOLS.md and HEARTBEAT.md to the per-agent description and the default reference/tree where the page presents the workspace inventory. Retain the first-use conditions for MEMORY.md and memory/. Add a documentation or generated-variant regression assertion that keeps the documented seeded-file set aligned with runtime behavior.
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
Addressed the current workspace-documentation change request.
Validation:
Fresh checks and human re-review are pending. Reviewer routing was not changed. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/agent-variant-docs.test.ts`:
- Around line 65-71: Update the test around the seededFiles assertions to
validate the documented inventory in both directions: ensure the rendered seeded
table, file tree, and summary contain exactly the seededFiles entries and reject
deferred paths such as MEMORY.md or memory/. Preserve the existing per-file
presence checks while adding assertions that detect undocumented extra entries.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: af02879e-e851-4baf-94a4-cced6c777464
📒 Files selected for processing (3)
ci/source-shape-test-budget.jsondocs/manage-sandboxes/workspace-files.mdxtest/agent-variant-docs.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
- docs/manage-sandboxes/workspace-files.mdx
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
The latest PR commit addresses the remaining workspace-inventory review finding.
The previous managed runtime activation failure is infrastructure-related. Image builds and direct agent startups passed, but the OpenClaw gateway and port forward did not become available within the runner deadline. Fresh required checks are running and will exercise this path again. Human review remains required because the prior change request remains active until the reviewer evaluates the updated branch. |
|
The managed-runtime activation failure is classified as infrastructure-related. The image builds and direct startups for OpenClaw, Hermes, and Deep Agents Code passed, while the managed OpenClaw gateway did not become available before the runner deadline. I have started the single permitted retry of the failed activation job. No code change is indicated by this failure. |
|
The single permitted retry is exhausted. It did not reach runtime activation because the rerun did not receive the three image-contract artifacts produced by the earlier successful build jobs; those producer jobs were not part of the failed-job retry. This is a CI orchestration blocker, not evidence of a PR-related failure. The prior direct startups for all three agents passed. A repository workflow owner must provide a fresh complete run or repair artifact reuse before this gate can pass. |
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
Current readiness blocker: the managed-image workflow fails while rebuilding the unchanged Hermes and Deep Agents Code images. Both jobs stop in the completed-image security inventory verification, before exercising this PR’s onboarding or workspace-documentation changes. This PR changes only five files and does not modify either managed image, its package inventory, or the verification step. The same base-image inventory drift is also reproducing on unrelated PRs. Classification: infrastructure/base-image drift, not PR-related and not a transient runner failure. I am not rerunning it because the deterministic assertion has already reproduced independently in both image jobs. The OpenClaw and staging jobs, the remaining repository checks, and automated review are still running. The PR stays unready until the managed-image baseline is corrected and every required gate passes. |
|
CI classification update:
I classify the four managed-image failures as shared CI or base-image drift rather than a PR-caused regression. Because the failure is deterministic across the variants, I am not rerunning those jobs. The independent advisor retry is still in progress. |
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Prekshi Vyas <prekshiv@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Summary
Resumed Local Ollama onboarding now uses the provider-neutral step title
Configuring inference provider. The OpenClaw workspace documentation distinguishes seeded templates from memory files created on use and states the exact default-workspace seeding conditions.Related Issue
Fixes #8853.
Changes
MEMORY.mdandmemory/paths.NEMOCLAW_MINIMAL_BOOTSTRAP=1.Type of Change
Quality Gates
Documentation Writer Review
docs-updatedDGX Station Hardware Evidence
Verification
Signed-off-by:line and every published commit before the latest update appeared asVerifiedin GitHubSigned-off-by: Yimo Jiang yimoj@nvidia.com