Skip to content

test(ci): remove stale base-image path expectations - #8778

Closed
jyaunches wants to merge 3 commits into
mainfrom
codex/base-image-contract-revert
Closed

test(ci): remove stale base-image path expectations#8778
jyaunches wants to merge 3 commits into
mainfrom
codex/base-image-contract-revert

Conversation

@jyaunches

@jyaunches jyaunches commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

PR #8775 restored the pre-#8761 workflow split and removed managed-image activation tests from .github/workflows/base-image.yaml. Three assertions added by #8748 and #8772 still require those paths, so CLI shard 8 now fails deterministically on unchanged main.

This removes only the stale real-workflow expectations. .github/workflows/managed-images.yaml remains the owner of the managed-image activation glob, and the base-image parser's synthetic reviewed-glob coverage remains intact.

Changes

  • Stop requiring two removed literal activation paths in the base-image workflow fixture.
  • Stop requiring the activation wildcard owned by the managed-images workflow.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: this aligns a support-test expectation with the workflow ownership restored by chore: revert codebase growth guardrails #8775 and changes no user-facing command, configuration, product workflow, default, or support claim.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Documentation Writer Review

  • Documentation writer subagent reviewed the completed changes
  • Result: no-docs-needed
  • Evidence: The commit under review only removes three stale path expectations from test/e2e/support/base-image-publication.test.ts. .github/workflows/base-image.yaml already excludes the managed-image activation tests, while .github/workflows/managed-images.yaml owns them; no user-facing command, configuration, product workflow, default, or support claim changes.
  • Agent: Codex Desktop

DGX Station Hardware Evidence

  • Tested on DGX Station
  • Tested commit:
  • Station profile/scenario:
  • Result:
  • Supporting evidence:

Verification

  • PR description includes a Signed-off-by: line and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run validate:pr passed after refreshing origin/main when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — command/result:
    • npm exec -- vitest run --project e2e-support test/e2e/support/base-image-publication.test.ts — 39/39 passed.
    • npm run test:changed — selected the changed E2E-support test; 39/39 passed.
    • npm run validate:pr — passed all pre-commit, commit-message, and pre-push checks after building the clean worktree's generated CLI artifacts.
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result: not applicable to a three-line assertion cleanup; the owning E2E-support suite and standard PR validation are the proportionate gates.
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Julie Yaunches jyaunches@nvidia.com

Summary by CodeRabbit

  • Tests
    • Updated end-to-end test expectations for base-image workflow paths.
    • Removed obsolete managed-image activation test entries while retaining credential, messaging, and tool-disclosure coverage.

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The end-to-end base-image publication test removes two managed-image activation paths from its expected workflow path list.

Changes

Base-image workflow path expectations

Layer / File(s) Summary
Update expected workflow paths
test/e2e/support/base-image-publication.test.ts
The expected path list removes two managed-image activation test globs and retains the credential, messaging, and tool-disclosure paths.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • NVIDIA/NemoClaw#8771: Both changes modify base-image workflow path handling for managed-image activation tests.
  • NVIDIA/NemoClaw#8772: This change removes the managed-image paths added by that PR from the expected path list.
  • NVIDIA/NemoClaw#8775: Both changes remove the same managed-image paths from base-image workflow expectations.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the removal of stale base-image path expectations, which matches the pull request's primary change.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/base-image-contract-revert

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage in commit 56d803a in the codex/base-image-con... branch remains at 96%, unchanged from commit 6df126c in the main branch.

TypeScript / code-coverage/cli

The overall coverage in commit 56d803a in the codex/base-image-con... branch remains at 82%, unchanged from commit d357554 in the main branch.

Show a code coverage summary of the most impacted files.
File main d357554 codex/base-image-con... 56d803a +/-
src/lib/actions...er-lifecycle.ts 94% 85% -9%
src/lib/onboard...age/contract.ts 93% 89% -4%
src/lib/state/registry.ts 89% 87% -2%
src/lib/state/config-io.ts 95% 93% -2%
src/lib/securit...ate-endpoint.ts 97% 95% -2%
src/lib/messagi...annel-config.ts 95% 93% -2%
src/lib/adapter...shell/client.ts 88% 90% +2%
src/lib/policy/...ne-exclusion.ts 87% 92% +5%
src/lib/onboard...eway-binding.ts 83% 88% +5%
src/lib/actions...-add-restart.ts 12% 20% +8%

Updated August 11, 2026 06:53 UTC

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — No blocking findings reported

Advisor assessment: No blocking advisor findings reported
Next action: No advisor follow-up needed.
Findings: 0 blockers · 0 warnings · 0 suggestions

Model lanes

  • GPT-5.6 Terra (primary): Completed · high confidence · 0 blockers · 0 warnings · 0 suggestions
  • Nemotron 3 Ultra (second opinion): Completed · high confidence · 0 blockers · 5 warnings · 0 suggestions
  • Model comparison: normalized findings differ; normalized terminology decisions match; normalized E2E selections differ; Nemotron reported the same number of blockers, 5 more warnings, the same number of suggestions.
3 additional E2E selections from the second opinion

Advisory only. The primary lane did not select these E2E jobs or targets.

  • managed-image-multiarch-startup: The completed second-opinion lane identified E2E coverage that the primary lane omitted.
  • managed-image-protected-runtime: The completed second-opinion lane identified E2E coverage that the primary lane omitted.
  • onboard-managed-image-buildless-e2e: The completed second-opinion lane identified E2E coverage that the primary lane omitted.

Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests.

E2E guidance

Advisory only. A maintainer can dispatch the default E2E suite for the commit under review.

Recommended E2E: None

Workflow run details

This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge.

@prekshivyas

Copy link
Copy Markdown
Collaborator

Closing as superseded by merged PRs #8634 and #8776. PR #8634 intentionally restored these managed-image activation paths to the base-image publisher and absorbed the baseline CI repairs; PR #8776 retained and merged the remaining stable-ID regression coverage. Applying this three-line deletion now would weaken the current publisher contract rather than repair it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants