test(ci): remove stale base-image path expectations - #8778
Conversation
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
📝 WalkthroughWalkthroughThe end-to-end base-image publication test removes two managed-image activation paths from its expected workflow path list. ChangesBase-image workflow path expectations
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 56d803a in the TypeScript / code-coverage/cliThe overall coverage in commit 56d803a in the Show a code coverage summary of the most impacted files.
Updated |
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
3 additional E2E selections from the second opinionAdvisory only. The primary lane did not select these E2E jobs or targets.
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite for the commit under review. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
|
Closing as superseded by merged PRs #8634 and #8776. PR #8634 intentionally restored these managed-image activation paths to the base-image publisher and absorbed the baseline CI repairs; PR #8776 retained and merged the remaining stable-ID regression coverage. Applying this three-line deletion now would weaken the current publisher contract rather than repair it. |
Summary
PR #8775 restored the pre-#8761 workflow split and removed managed-image activation tests from
.github/workflows/base-image.yaml. Three assertions added by #8748 and #8772 still require those paths, so CLI shard 8 now fails deterministically on unchangedmain.This removes only the stale real-workflow expectations.
.github/workflows/managed-images.yamlremains the owner of the managed-image activation glob, and the base-image parser's synthetic reviewed-glob coverage remains intact.Changes
Type of Change
Quality Gates
Documentation Writer Review
no-docs-neededtest/e2e/support/base-image-publication.test.ts..github/workflows/base-image.yamlalready excludes the managed-image activation tests, while.github/workflows/managed-images.yamlowns them; no user-facing command, configuration, product workflow, default, or support claim changes.DGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm exec -- vitest run --project e2e-support test/e2e/support/base-image-publication.test.ts— 39/39 passed.npm run test:changed— selected the changed E2E-support test; 39/39 passed.npm run validate:pr— passed all pre-commit, commit-message, and pre-push checks after building the clean worktree's generated CLI artifacts.npm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: not applicable to a three-line assertion cleanup; the owning E2E-support suite and standard PR validation are the proportionate gates.npm run docsbuilds without warnings (doc changes only)Signed-off-by: Julie Yaunches jyaunches@nvidia.com
Summary by CodeRabbit