chore(docs): apply v0.0.105 follow-up and bump Fern - #8764
Conversation
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
📝 WalkthroughWalkthroughDocumentation updates clarify feature auditing, validation retries, sandbox operations, GPU proof behavior, troubleshooting, changelog content, and Fern version metadata. ChangesDocumentation and metadata
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-8764.docs.buildwithfern.com/nemoclaw |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall coverage in commit 05e840d in the TypeScript / code-coverage/cliThe overall coverage in commit 05e840d in the Show a code coverage summary of the most impacted files.
Updated |
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
PR Review Advisor — No blocking findings reportedAdvisor assessment: No blocking advisor findings reported Model lanes
Second-opinion terminology and E2E selections are advisory. Live E2E does not run automatically for pull requests. 2 semantic terminology decisionsTerminology decisions are advisory. They affect the assessment only when a separate finding identifies concrete semantic impact.
E2E guidanceAdvisory only. A maintainer can dispatch the default E2E suite against this exact revision. Recommended E2E: None This automated review informs maintainers. Warnings and suggestions do not require a response. A maintainer decides whether to merge. |
miyoungc
changed the title
miyoungc
added
area: docs
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/reference/commands.mdx`:
- Line 4541: Update the NEMOCLAW_WSL_GPU_PROOF_TIMEOUT_MS documentation to
describe the parser’s actual contract: any positive finite number of
milliseconds is accepted, while invalid or non-positive values use the default.
Do not describe the value as an integer unless the corresponding parser
validation is also changed.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a17103f3-6635-44df-8d5a-2eacc0dcb37f
📒 Files selected for processing (9)
docs/.docs-skipdocs/changelog/2026-08-07.mdxdocs/inference/understand-provider-validation.mdxdocs/manage-sandboxes/recover-rebuild-sandboxes.mdxdocs/manage-sandboxes/uninstall-nemoclaw.mdxdocs/reference/commands.mdxdocs/reference/troubleshooting.mdxfern/fern.config.jsontest/fern-dependency-review.test.ts
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
Security review: PASS for the current branch revision. Scope: documentation source plus the Fern docs-only tool upgrade to 5.92.4. The change does not alter shipped runtime code, credentials, policy enforcement, sandbox boundaries, or product network behavior. Evidence reviewed:
Local validation after refreshing from current |
apurvvkumaria
left a comment
apurvvkumaria
left a comment
There was a problem hiding this comment.
Reviewed the documentation follow-up and Fern 5.92.4 upgrade after the branch refresh. The source-behavior wording, dependency evidence, focused tests, repository structure checks, documentation build, DCO declarations, and GitHub commit verification are complete. I found no remaining correctness, documentation, or security issue in the current change set. Required CI and automated review still need to finish before this PR is ready for the release train.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/fern-dependency-review.test.ts`:
- Around line 48-52: Strengthen the assertions for the “Complete Source Range
Ledger” rows in this test by verifying the expected range labels begin at
5.80.1, end at 5.92.4, and are contiguous, along with their per-range commit
counts. Keep the existing row-count and aggregate checks, and avoid relying only
on totals that could remain unchanged when ranges are omitted or replaced.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f7c73f34-ae4e-48c5-884a-c7bf3e59f9ce
📒 Files selected for processing (4)
docs/reference/commands.mdxdocs/security/fern-5.92.4-dependency-review.mdfern/fern.config.jsontest/fern-dependency-review.test.ts
🚧 Files skipped from review as they are similar to previous changes (2)
- fern/fern.config.json
- docs/reference/commands.mdx
| const ranges = tableRows("Complete Source Range Ledger"); | ||
| const concerns = tableRows("Concern Ledger"); | ||
|
|
||
| expect(ranges).toHaveLength(21); | ||
| expect(ranges.reduce((total, [, commits]) => total + Number(commits), 0)).toBe(225); | ||
| expect(ranges).toHaveLength(5); | ||
| expect(ranges.reduce((total, [, commits]) => total + Number(commits), 0)).toBe(194); |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Assert the source-range contract, not only its totals.
Lines 51-52 verify only five rows and an aggregate of 194 commits. These checks do not prove that the rows start at 5.80.1, end at 5.92.4, and remain contiguous. A ledger can omit or replace a range while preserving both totals. Assert the expected range labels and per-range commit counts, or validate endpoint contiguity.
Proposed assertion
- expect(ranges).toHaveLength(5);
- expect(ranges.reduce((total, [, commits]) => total + Number(commits), 0)).toBe(194);
+ expect(ranges.map(([range, commits]) => [range, commits])).toEqual([
+ ["`5.80.1` to `5.80.5`", "60"],
+ ["`5.80.5` to `5.86.0`", "42"],
+ ["`5.86.0` to `5.89.6`", "40"],
+ ["`5.89.6` to `5.92.2`", "46"],
+ ["`5.92.2` to `5.92.4`", "6"],
+ ]);As per path instructions, review tests for behavioral confidence rather than implementation lock-in.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| const ranges = tableRows("Complete Source Range Ledger"); | |
| const concerns = tableRows("Concern Ledger"); | |
| expect(ranges).toHaveLength(21); | |
| expect(ranges.reduce((total, [, commits]) => total + Number(commits), 0)).toBe(225); | |
| expect(ranges).toHaveLength(5); | |
| expect(ranges.reduce((total, [, commits]) => total + Number(commits), 0)).toBe(194); | |
| const ranges = tableRows("Complete Source Range Ledger"); | |
| const concerns = tableRows("Concern Ledger"); | |
| expect(ranges.map(([range, commits]) => [range, commits])).toEqual([ | |
| ["`5.80.1` to `5.80.5`", "60"], | |
| ["`5.80.5` to `5.86.0`", "42"], | |
| ["`5.86.0` to `5.89.6`", "40"], | |
| ["`5.89.6` to `5.92.2`", "46"], | |
| ["`5.92.2` to `5.92.4`", "6"], | |
| ]); |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/fern-dependency-review.test.ts` around lines 48 - 52, Strengthen the
assertions for the “Complete Source Range Ledger” rows in this test by verifying
the expected range labels begin at 5.80.1, end at 5.92.4, and are contiguous,
along with their per-range commit counts. Keep the existing row-count and
aggregate checks, and avoid relying only on totals that could remain unchanged
when ranges are omitted or replaced.
Source: Path instructions
|
Readiness is blocked by the PR review workflow, not by this change. The Nemotron advisory lane stopped twice with the same SDK tool-sequencing error while the other advisory lane completed and reported no findings. All other repository checks pass. The repository readiness checker therefore remains fail-closed because one advisory check is red and the published advisory result is incomplete. I will leave the branch unmerged and monitor for a workflow recovery or a new branch revision that starts a fresh run. |
3 participants
Summary
This change applies the bounded v0.0.105 documentation follow-up and upgrades the Fern CLI from 5.80.1 to 5.92.4.
The Fern upgrade now includes a repository-owned dependency review and executable evidence that binds the production pin to the reviewed package.
Changes
docs/.docs-skipso a mixed commit does not hide unrelated user-visible behavior.Type of Change
Quality Gates
Documentation Writer Review
docs-updatedDGX Station Hardware Evidence
Verification
Signed-off-by:line and every commit appears asVerifiedin GitHubpre-commit,commit-msg, andpre-pushhooks passed, ornpm run validate:prpassed after refreshingorigin/mainwhen hooks were skipped or unavailablenpm testfor broad runtime/test-harness changes;npm run checkfor repo-wide validation/coverage changes — command/result: Not applicable to this bounded documentation and docs-tooling change.npm run docsbuilds without warnings (doc changes only) — the build completed with zero errors and two existing warnings.Additional local checks after refreshing from current
main: test-title policy passed, Vitest project membership was exact across 2,297 candidates and seven projects, source-shape policy passed with 117 valid exceptions, andgit diff --checkpassed.Signed-off-by: Miyoung Choi miyoungc@nvidia.com
Summary by CodeRabbit