Skip to content

test(e2e): align Hermes GPU mode proof - #6725

Merged
cv merged 1 commit into
mainfrom
codex/fix-hermes-gpu-mode-proof
Jul 12, 2026
Merged

test(e2e): align Hermes GPU mode proof#6725
cv merged 1 commit into
mainfrom
codex/fix-hermes-gpu-mode-proof

Conversation

@cv

@cv cv commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Updates the Hermes GPU live proof to assert the canonical Docker container mode selected: message introduced by #6333. The stale Docker GPU mode selected: expectation failed the exact-candidate fallback E2E after container recreation, Ready state, and CUDA verification had already succeeded.

Changes

  • Require the canonical container-mode selection message for fallback and compatibility-only routes.
  • Verify that the native route does not emit the compatibility container-mode message.

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Quality Gates

  • Tests added or updated for changed behavior
  • Existing tests cover changed behavior — justification:
  • Tests not applicable — justification:
  • Docs updated for user-facing behavior changes
  • Docs not applicable — justification: This changes only an internal live-test assertion; user-facing GPU routing, configuration, commands, and documented behavior are unchanged.
  • Sensitive paths changed (security, policy, credentials, preflight, onboarding, inference, runner, sandbox, or messaging)
  • Sensitive-path review completed or maintainer-approved waiver recorded — reviewer/approval link/justification:
  • Non-success, skipped, or missing CI check accepted by maintainer — check name, approval link, and follow-up issue:

Verification

  • PR description includes the DCO sign-off declaration and every commit appears as Verified in GitHub
  • Normal pre-commit, commit-msg, and pre-push hooks passed, or npm run check:diff passed when hooks were skipped or unavailable
  • Targeted behavior tests pass for the current change set, or tests are marked not applicable above — npx vitest run --project e2e-support test/e2e/support/hermes-gpu-startup-fallback.test.ts test/e2e/support/hermes-gpu-startup-integrity.test.ts test/e2e/support/hermes-workflow-boundary.test.ts (38 passed); live-test collection passed for native, fallback, and compatibility-only scenarios
  • Applicable broad gate passed — npm test for broad runtime/test-harness changes; npm run check for repo-wide validation/coverage changes — command/result:
  • Quality Gates section completed with required justifications or waivers
  • No secrets, API keys, or credentials committed
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Carlos Villela cvillela@nvidia.com

Summary by CodeRabbit

  • Tests
    • Updated end-to-end validation to reflect revised Docker startup messaging.
    • Added coverage for container-mode logging in compatibility and fallback scenarios.
    • Confirmed container-mode messaging is absent for other GPU routes.

Signed-off-by: Carlos Villela <cvillela@nvidia.com>
@cv cv added the v0.0.81 label Jul 12, 2026
@cv cv self-assigned this Jul 12, 2026
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d5376f50-b265-47b3-a93c-1f8161b47e28

📥 Commits

Reviewing files that changed from the base of the PR and between e7e2ce6 and 50234a0.

📒 Files selected for processing (1)
  • test/e2e/live/hermes-gpu-startup-proof.ts

📝 Walkthrough

Walkthrough

The Hermes GPU startup proof test now checks for the Docker container mode selection message across compatibility-only, compatibility-fallback, and other GPU routes.

Changes

Hermes GPU startup proof

Layer / File(s) Summary
Update route log assertions
test/e2e/live/hermes-gpu-startup-proof.ts
Compatibility routes require Docker container mode selected:, while other routes assert that the message is absent.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested labels: bug-fix

Suggested reviewers: zyang-dev

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the E2E test update to the Hermes GPU mode proof.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-hermes-gpu-mode-proof

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall coverage remains at 96%, unchanged from the main branch.

TypeScript / code-coverage/cli

The overall coverage in the codex/fix-hermes-gpu... branch remains at 79%, unchanged from the main branch.

Show a code coverage summary of the most impacted files.
File main 6eb7ca7 codex/fix-hermes-gpu... 50234a0 +/-
src/lib/state/sandbox.ts 88% 76% -12%
src/lib/sandbox/config.ts 59% 73% +14%
src/lib/onboard...x-containers.ts 0% 84% +84%
src/lib/onboard...u-patch-mode.ts 0% 90% +90%
src/lib/onboard...-patch-clone.ts 0% 92% +92%
src/lib/onboard...tch-recreate.ts 0% 92% +92%
src/lib/onboard...-run-attempt.ts 0% 95% +95%
src/lib/onboard...-diagnostics.ts 0% 96% +96%
src/lib/onboard...er-gpu-route.ts 0% 96% +96%
src/lib/onboard...eate-attempt.ts 0% 100% +100%

Updated July 12, 2026 20:04 UTC
Code Coverage is in Public Preview. Learn more and provide us with your feedback.

@github-actions

Copy link
Copy Markdown
Contributor

E2E Advisor Recommendation

Required E2E: None
Optional E2E: None

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. Tests-only change to an existing live E2E assertion. The deterministic risk plan is tier 0 with no required jobs, and this does not alter runtime user flows or security boundaries.

Optional E2E

  • None.

New E2E recommendations

  • None.

@github-actions

github-actions Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor — Informational

Merge posture: Informational / low confidence
Primary next action: No advisor follow-up required beyond maintainer review.
Findings: 0 required · 0 warnings · 0 optional suggestions
Status: No actionable findings remain in the canonical review ledger.

Workflow run details

This is an automated review. Required findings need action before merge. Warnings and optional suggestions do not require a response or follow-up. A human maintainer makes the final merge decision.

@cv
cv merged commit 457311c into main Jul 12, 2026
69 of 72 checks passed
@cv
cv deleted the codex/fix-hermes-gpu-mode-proof branch July 12, 2026 20:18
@wscurran wscurran added area: e2e End-to-end tests, nightly failures, or validation infrastructure integration: hermes Hermes integration behavior labels Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: e2e End-to-end tests, nightly failures, or validation infrastructure integration: hermes Hermes integration behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants