docs(contributing): add npm link step to developer setup#1483
docs(contributing): add npm link step to developer setup#1483cv merged 7 commits intoNVIDIA:mainfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded a "Local Development Testing" subsection to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 56-61: The docs risk instructing users to run npm link from the
wrong directory (e.g., still in ./nemoclaw) which can link the plugin instead of
the root CLI; update the CONTRIBUTING.md step before the npm link command to
make the working directory explicit by telling users to return to the repo root
(or run the appropriate cd) so npm link targets the CLI package, then run npm
link and verify with the nemoclaw --version check.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3b8f0111-0648-4d9b-a5b7-76d01e93c77c
📒 Files selected for processing (1)
CONTRIBUTING.md
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
Thanks for this contribution @dknos — clean, well-scoped fix that addresses #1429 exactly. Appreciate you following up on the CodeRabbit working-directory feedback too. One blocker before we can merge: DCO sign-off missing. The Once that's in place, this is good to go. |
5bfe5e4 to
0a628f7
Compare
The nemoclaw CLI requires npm link to be available as a local command during development. This step was missing from the setup instructions. Fixes NVIDIA#1429 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: dknos <rneebo@gmail.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: dknos <rneebo@gmail.com>
Add explicit cd .. instruction since the previous build step leaves the user inside the nemoclaw/ subdirectory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: dknos <rneebo@gmail.com>
0a628f7 to
afc522e
Compare
Summary
npm linkstep to the developer setup section in CONTRIBUTING.mdnemoclawCLI to work locally during developmentTest plan
nemoclawcommand is available after setupFixes #1429
Fixes #989
🤖 Generated with Claude Code
Summary by CodeRabbit
Signed-off-by: dknos rneebo@gmail.com
Signed-off-by: dknos rneebo@gmail.com