Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SlurmRay launcher and transform API for launchers #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add SlurmRay launcher and transform API for launchers #159

wants to merge 1 commit into from

Conversation

hemildesai
Copy link
Collaborator

@hemildesai hemildesai commented Feb 21, 2025 •
edited
Loading

Example usage

SlurmExecutor(
    ...,
    launcher="slurm_ray"
)

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 21, 2025
View reviewed changes
src/nemo_run/core/execution/launcher.py
nsys_folder: str = "nsys_profile"
nsys_trace: list[str] = field(default_factory=lambda: ["nvtx", "cuda"])

def get_nsys_prefix(self, profile_dir: str) -> Optional[list[str]]:

Check notice

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.
src/nemo_run/core/execution/launcher.py
]
return args

def transform(self, cmd: list[str]) -> Optional[Script]: ...

Check notice

Code scanning / CodeQL

Statement has no effect Note

This statement has no effect.
@hemildesai hemildesai requested a review from ryantwolf February 21, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantwolf ryantwolf Awaiting requested review from ryantwolf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hemildesai