-
Notifications
You must be signed in to change notification settings - Fork 477
Add ability to choose LLM prompt template for value generation and flow generation #903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sklinglernv
wants to merge
3
commits into
develop
Choose a base branch
from
feature/template-selection
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,122 @@ | ||
# SPDX-FileCopyrightText: Copyright (c) 2023 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
# SPDX-License-Identifier: Apache-2.0 | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import logging | ||
|
||
from rich.logging import RichHandler | ||
|
||
from nemoguardrails import RailsConfig | ||
from tests.utils import TestChat | ||
|
||
FORMAT = "%(message)s" | ||
logging.basicConfig( | ||
level=logging.DEBUG, | ||
format=FORMAT, | ||
datefmt="[%X,%f]", | ||
handlers=[RichHandler(markup=True)], | ||
) | ||
|
||
config_1 = """ | ||
colang_version: "2.x" | ||
|
||
models: | ||
- type: main | ||
engine: openai | ||
model: gpt-3.5-turbo-instruct | ||
|
||
prompts: | ||
- task: generate_antonym | ||
models: | ||
- openai/gpt-3.5-turbo | ||
- openai/gpt-4 | ||
messages: | ||
- type: user | ||
content: |- | ||
Generate the antonym of the bot expression below. Use the syntax: bot say "<antonym goes here>". | ||
- type: user | ||
content: |- | ||
YOUR TASK: | ||
{{ flow_nld }} | ||
|
||
- task: repeat | ||
models: | ||
- openai/gpt-3.5-turbo | ||
- openai/gpt-4 | ||
messages: | ||
- type: system | ||
content: | | ||
Your are a value generation bot that needs to generate a value for the ${{ var_name }} variable based on instructions form the user. | ||
Be very precised and always pick the most suitable variable type (e.g. double quotes for strings). Only generated the value and do not provide any additional response. | ||
- type: user | ||
content: | | ||
{{ instructions }} three times | ||
Assign the generated value to: | ||
${{ var_name }} = | ||
|
||
""" | ||
|
||
|
||
def test_template_choice_in_value_generation(): | ||
"""Test template selection in value generation""" | ||
config = RailsConfig.from_content( | ||
colang_content=""" | ||
flow main | ||
match UtteranceUserActionFinished(final_transcript="hi") | ||
$test = ..."a random bird name{{% set template = 'repeat' %}}" | ||
await UtteranceBotAction(script=$test) | ||
""", | ||
yaml_content=config_1, | ||
) | ||
|
||
chat = TestChat( | ||
config, | ||
llm_completions=["'parrot, raven, peacock'"], | ||
) | ||
|
||
expected_prompt = "System: Your are a value generation bot that needs to generate a value for the $test variable based on instructions form the user.\nBe very precised and always pick the most suitable variable type (e.g. double quotes for strings). Only generated the value and do not provide any additional response.\nHuman: a random bird name three times\nAssign the generated value to:\n$test =" | ||
|
||
chat >> "hi" | ||
chat << "parrot, raven, peacock" | ||
assert chat.llm.prompt_history[0] == expected_prompt | ||
|
||
|
||
def test_template_choice_in_flow_generation(): | ||
"""Test template selection in flow generation""" | ||
config = RailsConfig.from_content( | ||
colang_content=""" | ||
import core | ||
flow generate antonym | ||
\"\"\" | ||
{% set template = "generate_antonym" %} | ||
bot say "lucky" | ||
\"\"\" | ||
... | ||
flow main | ||
match UtteranceUserActionFinished(final_transcript="hi") | ||
generate antonym | ||
""", | ||
yaml_content=config_1, | ||
) | ||
|
||
chat = TestChat( | ||
config, | ||
llm_completions=["bot say 'unfortunate'"], | ||
) | ||
|
||
expected_prompt = 'Human: Generate the antonym of the bot expression below. Use the syntax: bot say "<antonym goes here>".\nHuman: YOUR TASK:\n\n\nbot say "lucky"' | ||
|
||
chat >> "hi" | ||
chat << "unfortunate" | ||
assert chat.llm.prompt_history[0] == expected_prompt |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be wrong, but maybe