Support the new minhash 25.02 api #445
Open
+35
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Praateek <[email protected]>
sarahyurick
reviewed
Dec 20, 2024
Comment on lines
-42
to
+50
| # TODO remove this once 24.12.0 becomes the base version of cudf in nemo-curator | ||
| MINHASH_PERMUTED_AVAILABLE = CURRENT_CUDF_VERSION >= parse_version("24.12.0") or ( | ||
| CURRENT_CUDF_VERSION.is_prerelease | ||
| and CURRENT_CUDF_VERSION.base_version >= "24.12.0" | ||
| # TODO remove this once 25.02 becomes the base version of cudf in nemo-curator | ||
|
|
||
| # minhash in < 24.12 used to have a minhash(txt) api which was deprecated in favor of | ||
| # minhash(a, b) in 25.02 (in 24.12, minhash_permuted(a,b) was introduced) | ||
| MINHASH_DEPRECATED_API = ( | ||
| CURRENT_CUDF_VERSION.base_version < parse_version("24.12").base_version | ||
| ) | ||
| MINHASH_PERMUTED_AVAILABLE = (CURRENT_CUDF_VERSION.major == 24) & ( | ||
| CURRENT_CUDF_VERSION.minor == 12 |
There was a problem hiding this comment.
Wait I'm confused, why are we doing it for 24.10 and 24.12 instead of for 24.12 and 25.02?
There was a problem hiding this comment.
Maybe the code block here helps
if MINHASH_DEPRECATED_API:
# this is 24.10, the variable is named minhash deprecated api,
# because now cudf only needs four args, rather than two args
return ser.str.minhash(seeds=seeds, width=char_ngram)
else:
if MINHASH_PERMUTED_AVAILABLE:
# this is 24.12 because in this version the four arg function is called minhash_permuted
return ser.str.minhash_permuted(
a=seeds_a, b=seeds_b, seed=seeds[0][0], width=char_ngram
)
else:
# this is the 25.02 case where it's neither the deprecated case neither permuted is available
return ser.str.minhash(a=seeds_a, b=seeds_b, seed=seeds[0][0], width=char_ngram)There was a problem hiding this comment.
Ah ok I see, thanks! So are we waiting until the next NeMo Curator release (which will have 24.12 as the stable RAPIDS version) before removing MINHASH_DEPRECATED_API?
There was a problem hiding this comment.
Yes that's correct! And 25.02+ we wouldn't need any of these variables
sarahyurick
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #426 and piggy backs on https://github.com/NVIDIA/NeMo-Curator/pull/442/files
Checklist