-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add RAPIDS Nightly to GPU CI #436
base: main
Are you sure you want to change the base?
[WIP] Add RAPIDS Nightly to GPU CI #436
Conversation
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
… revert this change -> 436 Signed-off-by: Praateek <[email protected]>
Signed-off-by: Praateek <[email protected]>
if [ "$BUILD_TYPE" = "nightly" ]; then \ | ||
pip install ".[all_nightly]"; \ | ||
else \ | ||
pip install ".[all]"; \ | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to check if the nightly can use the same caching logic as stable, or if nightly should just always build a fresh non-cached container.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, wanted to flag this explicitly as we do some curator-update optimization above, and I want to ensure if branching doesn't mess with it.
cc @ko3n1g
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these optimizations come from the base-image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, if they do even if the base-image tag is unchanged b/c they overwrite it we should extend this build-workflow so that we can force pull the base image. In all other cases we don't need to be worried about caching i believe
Ok so here my suggestion:
|
Description
Usage
# Add snippet demonstrating usage
Checklist