Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modules to be in a single class and dataframe backend checking #379

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ryantwolf
Copy link
Collaborator

@ryantwolf ryantwolf commented Nov 18, 2024

Description

This PR does a couple of things:

  • Refactor ScoreFilter and DocumentFilter to be a single module.
  • Refactor Modify and DocumentModifier to be a single module.
  • Add a generic Module abstract base class that can validate the necessary backend of each module.
  • Add a ToBackend module that converts between backends in a pipeline.

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

@ryantwolf ryantwolf changed the title Refactor the Filtering to Combing ScoreFilter and DocumentFilter Refactor modules to be in a single class and dataframe backend checking Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant