Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: minor improvements to functional tests #379

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Conversation

ashors1
Copy link
Collaborator

@ashors1 ashors1 commented Nov 5, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

Signed-off-by: ashors1 <[email protected]>
@ashors1 ashors1 requested a review from terrykong November 5, 2024 20:34
@ashors1 ashors1 added the Run CICD Set + un-set to retrigger label Nov 5, 2024
@ashors1 ashors1 changed the title Minor improvements to functional tests ci: minor improvements to functional tests Nov 5, 2024
Signed-off-by: ashors1 <[email protected]>
@ashors1 ashors1 added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Nov 5, 2024
Signed-off-by: ashors1 <[email protected]>
@ashors1 ashors1 added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Nov 5, 2024
@ashors1 ashors1 added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Nov 7, 2024
@ashors1 ashors1 requested a review from ko3n1g November 8, 2024 22:44
@terrykong terrykong added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Nov 8, 2024
@terrykong terrykong enabled auto-merge (squash) November 8, 2024 22:53
@terrykong terrykong merged commit 7816a72 into main Nov 8, 2024
16 checks passed
@terrykong terrykong deleted the ashors/ci-fixes branch November 8, 2024 23:13
@github-actions github-actions bot mentioned this pull request Nov 12, 2024
8 tasks
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Nov 22, 2024
Signed-off-by: ashors1 <[email protected]>
Co-authored-by: Terry Kong <[email protected]>
Signed-off-by: abukharin <[email protected]>
abukharin3 pushed a commit to abukharin3/NeMo-Aligner that referenced this pull request Nov 22, 2024
Signed-off-by: ashors1 <[email protected]>
Co-authored-by: Terry Kong <[email protected]>
Signed-off-by: abukharin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants