Skip to content

Fix improper span closures on errors and LangchainCallbackHandler memory leaks #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Fix improper span closures on errors and LangchainCallbackHandler memory leaks #839

wants to merge 4 commits into from

Conversation

@mpenn
Copy link
Contributor

@mpenn mpenn commented Sep 23, 2025

Description

Closes

This PR improves error handling during function invocation and llm/tool call failures in LangchainCallbackHandler to ensure proper closures of spans during export. This ensures proper nesting of traces. This includes an the following updates to the IntermediateStep:

  • addition of IntermediateStepPayload.status attribute to represent invocation success/failure
  • ErrorDetails to provide additional error details in the metadata attribute

This PR also resolves memory leaks in the LangchainCallbackHandler

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license.
    • Any contribution which contains commits that are not Signed-Off will not be accepted.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@mpenn
Enhance error handling and event tracking in Context and LangchainPro…
8c65ed3 
…filerHandler

- Introduced standardized error details capturing in IntermediateStepPayload with ErrorDetails model.
- Updated Context class to emit success or error events based on function execution outcomes, including detailed error metadata.
- Enhanced LangchainProfilerHandler to handle LLM and tool errors, pushing error events with relevant details to the step manager.
- Added EventStatus enumeration to track the status of intermediate steps, improving observability in processing flows.

This ensures proper nesting of spans, event in the event of tool
call/llm/function invocation failures

Signed-off-by: Matthew Penn <[email protected]>
@mpenn
Update test_span_exporter.py tests
a5e307b 
Signed-off-by: Matthew Penn <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025 •
edited
Loading

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mpenn mpenn self-assigned this Sep 23, 2025
@mpenn mpenn added bug Something isn't working non-breaking Non-breaking change labels Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mpenn mpenn

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mpenn