Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log exception dict, example and doc updates #3307

Merged
merged 5 commits into from
Mar 26, 2025
Merged

Fix log exception dict, example and doc updates #3307

merged 5 commits into from
Mar 26, 2025

Conversation

SYangster
Copy link
Collaborator

@SYangster SYangster commented Mar 18, 2025 •
edited
Loading

Addresses FLARE-2416, FLARE-2429, and FLARE-2428

  • Fix issue for log exception with dictionaries for json formatter @nvidianz
  • Clarify LoggerNameFilter behavior for allowing all log records with level > INFO, added argument
  • Update example and documentation simulator log arguments (for simulator examples, keeping the default LogMode.CONCISE)
  • Will cherry-pick to 2.6 after merge

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

chesterxgchen
chesterxgchen reviewed Mar 19, 2025
View reviewed changes
Copy link
Collaborator

@chesterxgchen chesterxgchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some comments

@SYangster
Copy link
Collaborator Author

/build

@SYangster
Copy link
Collaborator Author

/build

YuanTingHsieh
YuanTingHsieh approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@YuanTingHsieh YuanTingHsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

nvidianz
nvidianz approved these changes Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@nvidianz nvidianz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuanTingHsieh
Copy link
Collaborator

/build

@SYangster SYangster mentioned this pull request Mar 25, 2025
Merged
6 tasks
@YuanTingHsieh
Copy link
Collaborator

/build

@chesterxgchen
Copy link
Collaborator

/build

@chesterxgchen chesterxgchen merged commit 17fa9be into NVIDIA:main Mar 26, 2025
20 checks passed
IsaacYangSLA pushed a commit that referenced this pull request Mar 27, 2025
@SYangster @chesterxgchen
[2.6] Fix log exception dict, example and doc updates (#3328)
0f72f31 
cherry-pick from #3307

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Quick tests passed locally by running `./runtest.sh`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated.

---------

Co-authored-by: Chester Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuanTingHsieh YuanTingHsieh YuanTingHsieh approved these changes

@nvidianz nvidianz nvidianz approved these changes

@nvkevlu nvkevlu Awaiting requested review from nvkevlu

@chesterxgchen chesterxgchen Awaiting requested review from chesterxgchen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SYangster @YuanTingHsieh @chesterxgchen @nvidianz