Cherry-pick PR #3302 #3305
Merged
Cherry-pick PR #3302 #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NVIDIA#3302) more information during dashboard launch. This PR fixes the issue with updated UI and logic. ### Description Dashboard initial user (project admin) now requires organization name. The env var `NVFL_CREDENTIAL` now has format as 'email:passowrd:org_name.' All user facing operations requires to update to support this new format. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [x] Quick tests passed locally by running `./runtest.sh`. - [ ] In-line docstrings updated. - [ ] Documentation updated.
IsaacYangSLA
requested review from
chesterxgchen,
YuanTingHsieh,
yanchengnv and
nvidianz
nvidianz
approved these changes
Mar 18, 2025
|
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… (#3302)
more information during dashboard launch. This PR fixes the issue with updated UI and logic.
Description
Dashboard initial user (project admin) now requires organization name. The env var
NVFL_CREDENTIALnow has format as'email:passowrd:org_name.' All user facing operations requires to update to support this new format.
Types of changes
./runtest.sh.Fixes # .
Description
A few sentences describing the changes proposed in this pull request.
Types of changes
./runtest.sh.