Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code for demo video #3303

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

YuanTingHsieh
Copy link
Collaborator

Description

Update code and add notebook for demo video

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

"source": [
"The beauty of working with NVFlare is that you can quickly adjust the model architecture or job parameters. All you need to do is edit the contents inside the pre-configured job files.\n",
"\n",
"For example, you can open a new tab in Jupyter Notebook to edit the model file or the config file. This allows you to change things like the architecture of your model, learning rate, batch size, and more, directly within the notebook."
Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 Mar 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we add another exp after the first one to show how easy it is to use another model?

"Now lets make some modifications to our model and try the new one out"
"cp /tmp/nvflare/workspaces/edge_example/prod_00/[email protected]/transfer/cifar_10_mobile_et /tmp/nvflare/workspaces/edge_example/prod_00/[email protected]/transfer/cifar_10_mobile_et_mod"
add an fc layer and save
"submit_job cifar_10_mobile_et_mod"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main point is no change needed at device side

Copy link
Collaborator

@ZiyueXu77 ZiyueXu77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One comment about showing how easy it is to switch to a different model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants