-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVFLARE pre-installer #3295
Open
chesterxgchen
wants to merge
20
commits into
NVIDIA:main
Choose a base branch
from
chesterxgchen:pre-installer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
NVFLARE pre-installer #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
82c3e71
to
2d550f0
Compare
/build |
1 similar comment
/build |
ea4d2c7
to
7f1bb6f
Compare
12efa09
to
7591119
Compare
/build |
1 similar comment
/build |
1b9d395
to
70e09fe
Compare
/build |
/build |
12f32e3
to
f66cff0
Compare
/build |
1 similar comment
/build |
42a6339
to
99beab3
Compare
/build |
chesterxgchen
commented
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
responded to comments
/build |
/build |
YuanTingHsieh
previously approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM
/build |
3 similar comments
/build |
/build |
/build |
add space to trigger the build
/build |
/build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NVFLARE Code Pre-Installer
This tool helps install NVFLARE application code and libraries before running federated learning jobs.
Overview
The code pre-installer handles:
Directory Structure
Expected application code zip structure:
or
Here is an example of creating a folder structure for pre-installation:
For example, if the app name is
fedavg
, the directory structure would look like this:Tree structure of the job configuration:
Then we can simply copy the
fedavg
folder to the pre-install folder:If you have shared code (such as Python modules with nested folders and files) in "/tmp/nvflare/jobs/workdir/pt", copy it to the application-share directory:
You should have something like the following:
The application.zip file will be created in the
/tmp/nvflare/
directory.Usage
Command Line Interface
Arguments:
-a, --application
: Path to application code zip file (required)-p, --install-prefix
: Installation prefix (default: /opt/nvflare/apps)-s, --site-name
: Target site name e.g., site-1, server (required)-ts, --target_shared_dir
: Target shared directory path (default: /local/custom)-debug, --debug
: Enable debug modeExample
Application Code Structure
The application zip file should have the following structure:
job_name/
: Application directory containing site-specific codemeta.json
: Application metadata fileapp_site-*/custom/
: Site-specific custom code directoriesapplication-share/
: Shared code directoryInstallation Paths
<install-prefix>/<job-name>/
/local/custom/
Error Handling
The installer will fail if:
Notes
Types of changes
./runtest.sh
.