-
Notifications
You must be signed in to change notification settings - Fork 243
Clean up Puzzle Compress Tutorial #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/compress #711 +/- ##
====================================================
- Coverage 74.47% 74.38% -0.09%
====================================================
Files 183 185 +2
Lines 18416 18521 +105
====================================================
+ Hits 13715 13777 +62
- Misses 4701 4744 +43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| from .base_hooks import * | ||
| from .base_hooks_analysis import * | ||
| from .megatron_hooks import * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont want to remove it but rather guard the import so if megatron is not present, this does not raise an error. Like so:
from modelopt.torch.utils import import_plugin
with import_plugin("megatron_hooks"):
from .megatron_hooks import *There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks
kevalmorabia97
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the cleanup!
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
|
@LianaMikael you'll need to fix code quality errors for the markdown: https://github.com/NVIDIA/Model-Optimizer/actions/runs/20377066546/job/58558289581?pr=711#step:5:129 |
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
What does this PR do?
This PR updates the Puzzle compress tutorial: