Skip to content

Conversation

@LianaMikael
Copy link

@LianaMikael LianaMikael commented Dec 19, 2025

What does this PR do?

This PR updates the Puzzle compress tutorial:

  • add vLLM inference benchmarking
  • remove verbose logs
  • add more information on how to choose config parameters
  • fix unused import

Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.38%. Comparing base (1d8bd20) to head (283679e).
⚠️ Report is 2 commits behind head on feature/compress.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature/compress     #711      +/-   ##
====================================================
- Coverage             74.47%   74.38%   -0.09%     
====================================================
  Files                   183      185       +2     
  Lines                 18416    18521     +105     
====================================================
+ Hits                  13715    13777      +62     
- Misses                 4701     4744      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


from .base_hooks import *
from .base_hooks_analysis import *
from .megatron_hooks import *
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont want to remove it but rather guard the import so if megatron is not present, this does not raise an error. Like so:

from modelopt.torch.utils import import_plugin

with import_plugin("megatron_hooks"):
    from .megatron_hooks import *

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks

Copy link
Collaborator

@kevalmorabia97 kevalmorabia97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the cleanup!

LianaMikael and others added 3 commits December 19, 2025 12:25
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
@kevalmorabia97 kevalmorabia97 enabled auto-merge (squash) December 19, 2025 17:02
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
@kevalmorabia97
Copy link
Collaborator

Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
Signed-off-by: Liana Mikaelyan <lmikaelyan@nvidia.com>
@kevalmorabia97 kevalmorabia97 merged commit db866d9 into feature/compress Dec 22, 2025
22 checks passed
@kevalmorabia97 kevalmorabia97 deleted the lmikaelyan/puzzle-tutorial branch December 22, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants