-
Notifications
You must be signed in to change notification settings - Fork 232
Registry interface for custom quantization functional backend #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0eac522 to
6e4c43f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #683 +/- ##
==========================================
+ Coverage 74.65% 74.69% +0.03%
==========================================
Files 192 192
Lines 18909 18946 +37
==========================================
+ Hits 14117 14152 +35
- Misses 4792 4794 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6e4c43f to
5cb5ae8
Compare
meenchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, one question for model restore, do users need to register custom backends before restoring models?
|
Yes, the backend info is stored in the modelopt state. After restore if this backend is not found, an error will be raised. |
8af2a0c to
7494116
Compare
7494116 to
9b6e0fa
Compare
c16e599 to
4320a05
Compare
…/modelopt-r-150!2) Added tests, minor changes Signed-off-by: realAsma <[email protected]> minor Signed-off-by: realAsma <[email protected]> minor Signed-off-by: realAsma <[email protected]> cleaned up implementation Signed-off-by: realAsma <[email protected]> more clean ups Signed-off-by: realAsma <[email protected]> addressed reviewer comments minor Signed-off-by: realAsma <[email protected]> rank 0 only warning minor Signed-off-by: realAsma <[email protected]>
Signed-off-by: realAsma <[email protected]>
803f9b0 to
cdbb918
Compare
What does this PR do?
Type of change: ?
Overview:
Add registry interface for custom quantization functional backend
Usage
see
tests/unit/torch/quantization/test_custom_backend.pyfor usage example.Testing
Before your PR is "Ready for review"
Additional Information